-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parametric function for Chain
#1155
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1155 +/- ##
=======================================
Coverage 87.79% 87.79%
=======================================
Files 193 193
Lines 6046 6057 +11
=======================================
+ Hits 5308 5318 +10
- Misses 738 739 +1 ☔ View full report in Codecov by Sentry. |
Without having tried this out to see how well it would work, I’d actually probably lean towards continuing to decompose these into (I’m actually planning to tweak these decomposing methods to make use of reusable buffers that I think will significantly reduce the performance penalty for performing multiple sub-integrals.) |
Yes, I think you are right @mikeingold. But I think having a parametric function for those geometries can be helpful nevertheless like in the example I gave above. |
Agreed. I can definitely imagine other uses where having these functions would be useful. |
Co-authored-by: Júlio Hoffimann <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ometry/Meshes.jl into parametric-function-ring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JoshuaLampert. Let's just wait for the tests before merging it.
When do you plan to release a new version @juliohm? |
Just waiting for a new fix on the new ValidCoords transform. Will release a
patch today or tomorrow at most.
Em qui., 19 de dez. de 2024, 10:57, Joshua Lampert ***@***.***>
escreveu:
… When do you plan to release a new version @juliohm
<https://github.com/juliohm>?
—
Reply to this email directly, view it on GitHub
<#1155 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZQW3MRYWJGFL34UTZW4NT2GLGGDAVCNFSM6AAAAABT3EYW72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJUGEZTKNRSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@JoshuaLampert released a patch to avoid blocking your work: JuliaRegistries/General#121670 Other possible ValidCoords fixes will come in a future patch. |
Great, thanks! |
This adds a parametric function for$t\in [0,1]$ . My use case is sampling at the boundary of
Chain
s, such that aRing
or aRope
can be evaluated at a parameterNgon
s andBox
es. I stumbled upon this by trying:where the last failed before.
cc @mikeingold: We could think of using this to make the specializations for
Rope
andRing
in MeshIntegrals.jl obsolete.