-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more analytical unit tests #166
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 181 181
=========================================
Hits 181 181 ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Not sure why Downgrade fails... |
That's why: https://github.com/JuliaGeometry/MeshIntegrals.jl/actions/runs/12840564494/job/35809354687?pr=166#step:8:477. The necessary diff is also given there. Aqua.jl wants the entries to be ordered alphabetically. This wasn't caught in the previous PR already because we skip CI for changes under docs/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just out of interest: How did you come up with the functions and their solutions? Did you compute the solutions by hand, did you use some symbolic solver or similar, or did you find them in some reference, or something else?
Oooohhhhh… I guess they’re using the sorting convention that all upper-case letters come before lower-case letters. |
Usually I hand-derive integral problems and just choose an integrand function that produces a non-zero solution but is also still pretty reasonable to derive by hand. The The others in this PR actually came from experimenting with an LLM (GPT 4o) which was surprisingly competent at suggesting test cases with step-by-step derived solutions. I just guided the model a bit and then validated the provided solution by hand. |
Sounds good. |
Thanks! |
More progress toward #67