-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "run inference in generated function (#76)" #81
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 85.41% 85.93% +0.52%
==========================================
Files 5 5
Lines 377 320 -57
==========================================
- Hits 322 275 -47
+ Misses 55 45 -10 ☔ View full report in Codecov by Sentry. |
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
Benchmark ResultJudge resultBenchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
Architecture: x86_64
|
Thanks for taking care of this! Could we give some time to Pepijn to respond with his plans, as he spearheaded these past improvements (and they are quite valuable)? It is holiday season right now so things can be a bit slow. If it is a quick fix we can just wait for that. If it is something he does not have the bandwidth for (perfectly understandable given that it is all volunteer efforts by everyone here), or if it is something that would take a while, we should proceed with this reversal. However, could you please preserve the tests and mark them as |
Apologies, I did not see the message Pepijn had posted on the other thread. Could you please preserve the tests (now |
Good call.
Thanks. I'll take care of that and release a new patch version. |
Reverts #76 due to #80.
@Krastanov @pepijndevos @marcom
EDIT: Fixes #80