Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix INT128_MIN write #1152

Merged
merged 4 commits into from
Jan 10, 2025
Merged

fix INT128_MIN write #1152

merged 4 commits into from
Jan 10, 2025

Conversation

belous-dp
Copy link
Contributor

this PR fixes #1151

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (41a6875) to head (39a57a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   90.47%   89.99%   -0.48%     
==========================================
  Files           9        8       -1     
  Lines        2319     2288      -31     
==========================================
- Hits         2098     2059      -39     
- Misses        221      229       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhz2

This comment was marked as resolved.

Co-authored-by: Nathan Zimmerberg <[email protected]>
test/write.jl Outdated
Comment on lines 199 to 204
# 1151
(
[(a=Int128(-170141183460469231731687303715884105728),)],
NamedTuple(),
"a\n-170141183460469231731687303715884105728\n"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a test with BigInt as well to avoid future regressions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@nhz2 nhz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. I did a basic benchmark with:

using BenchmarkTools, CSV
@btime CSV.writecell($(zeros(UInt8,1000)), 1, 100, $(IOBuffer()), -1234567890, nothing)

And I don't see a major performance regression, so I think this is ready to be merged.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for hte slow review.

@quinnj quinnj merged commit 8207959 into JuliaData:main Jan 10, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INT128_MIN write error
3 participants