-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix INT128_MIN write #1152
fix INT128_MIN write #1152
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 90.47% 89.99% -0.48%
==========================================
Files 9 8 -1
Lines 2319 2288 -31
==========================================
- Hits 2098 2059 -39
- Misses 221 229 +8 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Nathan Zimmerberg <[email protected]>
test/write.jl
Outdated
# 1151 | ||
( | ||
[(a=Int128(-170141183460469231731687303715884105728),)], | ||
NamedTuple(), | ||
"a\n-170141183460469231731687303715884105728\n" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a test with BigInt
as well to avoid future regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this. I did a basic benchmark with:
using BenchmarkTools, CSV
@btime CSV.writecell($(zeros(UInt8,1000)), 1, 100, $(IOBuffer()), -1234567890, nothing)
And I don't see a major performance regression, so I think this is ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry for hte slow review.
this PR fixes #1151