Skip to content

Commit

Permalink
Drop most SpreeService classes
Browse files Browse the repository at this point in the history
they just delegated method to other classes, no idea why or how that
would come in handy, feels like just more files and code to keep track of
  • Loading branch information
huoxito committed Dec 16, 2014
1 parent 4fce921 commit eda4fae
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 90 deletions.
20 changes: 0 additions & 20 deletions lib/Spree_services/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,26 +9,6 @@ def initialize(service_name, payload, config)
@service_name = service_name
end

def upsert_contact_with_account!
Integration::ContactAccount.new(config, payload[service_name]).upsert!
end

def upsert_lineitems!
Integration::LineItem.new(config, payload[service_name]).import!
end

def upsert_payments!
Integration::Payment.new(config, payload[service_name]).import!
end

def upsert_products!
Integration::Product.new(config, payload).import_from_order!
end

def upsert_order!
Integration::Order.new(config, payload).upsert!
end

def handle_returns!
Integration::Return.new(config, payload[service_name]).handle_all!
end
Expand Down
8 changes: 0 additions & 8 deletions lib/Spree_services/line_item.rb

This file was deleted.

8 changes: 0 additions & 8 deletions lib/Spree_services/order.rb

This file was deleted.

8 changes: 0 additions & 8 deletions lib/Spree_services/payment.rb

This file was deleted.

3 changes: 0 additions & 3 deletions lib/salesforce_integration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@
require 'restforce'

require 'Spree_services/base'
require 'Spree_services/order'
require 'Spree_services/line_item'
require 'Spree_services/payment'
require 'Spree_services/return'

require 'integrations/base'
Expand Down
10 changes: 5 additions & 5 deletions salesforce_endpoint.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ class SalesforceEndpoint < EndpointBase::Sinatra::Base

['/add_order', '/update_order'].each do |path|
post path do
SpreeService::Order.new(@payload, @config).upsert_contact_with_account!
SpreeService::Order.new(@payload, @config).upsert_order!
Integration::ContactAccount.new(@config, @payload[:order]).upsert!
Integration::Order.new(@config, @payload).upsert!

Integration::Product.new(@config, @payload).import_from_order!

SpreeService::Order.new(@payload, @config).upsert_lineitems!
SpreeService::Order.new(@payload, @config).upsert_payments!
Integration::LineItem.new(@config, @payload[:order]).import!
Integration::Payment.new(@config, @payload[:order]).import!

result 200, "Opportunity ##{@payload["order"]["id"]} sent to Salesforce"
result 200, "Opportunity # #{@payload["order"]["id"]} sent to Salesforce"
end
end

Expand Down
26 changes: 0 additions & 26 deletions spec/lib/Spree_services/base_spec.rb

This file was deleted.

12 changes: 0 additions & 12 deletions spec/lib/Spree_services/order_spec.rb

This file was deleted.

0 comments on commit eda4fae

Please sign in to comment.