Handle empty product payload on /get_products

lib/SF_services/base.rb

@@ -1,4 +1,13 @@
 module SFService
+  # Note about `query` methods: 
+  #
+  #   http://www.salesforce.com/us/developer/docs/api_rest/Content/resources_query.htm
+  #
+  #   If the query results are too large, the response contains the first batch
+  #   of results and a query identifier in the nextRecordsUrl field of the
+  #   response. The identifier can be used in an additional request to retrieve
+  #   the next batch.
+  #
   class Base
     attr_reader :salesforce, :config, :model_name
 

lib/integrations/product.rb

@@ -15,8 +15,9 @@ def upsert!(item = nil)
 
     def fetch_updates
       products = product_service.latest_updates config[:salesforce_products_since]
-      product_ids = products.map { |p| "'#{p["Id"]}'" }.join(", ")
+      return [] if products.to_a.empty?
 
+      product_ids = products.map { |p| "'#{p["Id"]}'" }.join(", ")
       prices = product_service.find_prices_by_product_ids product_ids
 
       products.map do |product|

spec/salesforce_endpoint_spec.rb

@@ -100,4 +100,16 @@
       expect(json_response["products"]).to be_a Array
     end
   end
+
+  it "empty get products result" do
+    payload = {
+      parameters: config.merge(salesforce_products_since: "2014-10-24T19:14:57-03:00")
+    }
+
+    VCR.use_cassette "requests/get_products_empty" do
+      post "/get_products", payload.to_json, auth
+      expect(json_response["summary"]).to be_nil
+      expect(last_response.status).to eq 200
+    end
+  end
 end