add libraries visited to itemsholder #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
codewithjulie
force-pushed
the
all-libraries-visited
branch
from
d72d37f to
fa9ae05
Compare
| * Cache-based wrapper around localStorage. | ||
| */ | ||
| public readonly itemsHolder: ItemsHoldr< | ||
| Record<string, boolean>>; |
There was a problem hiding this comment.
This reminds me, I need to set up CI to catch formatting issues. And commit hooks. #22.
| this.game.itemsHolder.setItem(other.title, true); | ||
| const libraries = ["AngularLibrary", "ReactLibrary", "SolidLibrary", "SvelteLibrary", "VueLibrary" ]; | ||
| if(libraries.every((library) => this.game.itemsHolder.getItem(library))) { | ||
| window.open("https://hi.joshuakgoldberg.com", "_blank") |
I still love this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What does this PR do? Why?
It adds the libraries a user has visited to itemsholder and if all libraries have been visited they get a nice surprise ;)
PR Checklist