Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: heimdall-common replacements #241

Merged
merged 7 commits into from
Dec 20, 2023
Merged

chore: heimdall-common replacements #241

merged 7 commits into from
Dec 20, 2023

Conversation

iankressin
Copy link
Contributor

Motivation

Addresses #240

@iankressin iankressin marked this pull request as ready for review December 15, 2023 12:45
@Jon-Becker
Copy link
Owner

Took a glance, looks good! I'll need to review more tomorrow morning & check each module but i'm afk right now.

Thank you so much for this ❤️

@Jon-Becker Jon-Becker changed the title Refactor/heimdall common replacements chore: heimdall-common replacements Dec 16, 2023
@Jon-Becker Jon-Becker linked an issue Dec 16, 2023 that may be closed by this pull request
Replace snippets with new heimdall-common functions #240
Closed
Jon-Becker
Jon-Becker requested changes Dec 16, 2023
View reviewed changes
Copy link
Owner

@Jon-Becker Jon-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to cover heimdall-core::dump, heimdall-core::inspect, heimdall-core::snapshot, as well.

otherwise, looking great!

@iankressin
Copy link
Contributor Author

Looks like we need to cover heimdall-core::dump, heimdall-core::inspect, heimdall-core::snapshot, as well.

otherwise, looking great!

I'll take a look at those later today 🫡

@iankressin
Copy link
Contributor Author

Looks like we need to cover heimdall-core::dump, heimdall-core::inspect, heimdall-core::snapshot, as well.

otherwise, looking great!

Made the changes for heimdall-core::dump and heimdall-core::inspect.

heimdall-core::snapshot is already using all the functions calls listed on the issue, since they were introduced on #198, which was the snapshot module refactor

Jon-Becker
Jon-Becker approved these changes Dec 20, 2023
View reviewed changes
Copy link
Owner

@Jon-Becker Jon-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@Jon-Becker Jon-Becker merged commit 769a33f into Jon-Becker:main Dec 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jon-Becker Jon-Becker Jon-Becker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace snippets with new heimdall-common functions
2 participants
@iankressin @Jon-Becker