Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate outputs by chain #185

Merged

Conversation

iankressin
Copy link
Contributor

Motivation

Fixes #181

Solution

Simply fetches chain id from rpc and includes on the path of snapshot file.

@iankressin iankressin changed the title Feat/separate output snapshots by chain feat: separate output snapshots by chain Nov 19, 2023
@Jon-Becker Jon-Becker changed the title feat: separate output snapshots by chain feat: separate outputs by chain Nov 19, 2023
cli/src/main.rs Outdated Show resolved Hide resolved
@Jon-Becker
Copy link
Owner

by the way, you can run cargo +nightly fmt to automatically format code to pass linting checks :D
if you pre-commit install, on commit it will:

  • automatically cargo c
  • automatically format
  • run clippy

Copy link
Owner

@Jon-Becker Jon-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@iankressin
Copy link
Contributor Author

by the way, you can run cargo +nightly fmt to automatically format code to pass linting checks :D if you pre-commit install, on commit it will:

  • automatically cargo c
  • automatically format
  • run clippy

Awesome! I'm fairly new to Rust, so all sorts of advice are welcome. Thanks

@Jon-Becker Jon-Becker merged commit 21a0b5f into Jon-Becker:main Nov 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Chain ID in the output directory when passing an address
2 participants