perf(logging): impl Default for Logger, add timestamp to messages

common/Cargo.toml

@@ -26,3 +26,4 @@ tokio = {version = "1", features = ["full"]}
 strsim = "0.10.0"
 async-recursion = "1.0.5"
 async-trait = "0.1.51"
+chrono = "0.4.31"

common/src/ether/compiler.rs

@@ -4,8 +4,7 @@ use crate::io::logging::Logger;
 // for example: (solc, 0.8.10) or (vyper, 0.2.16)
 pub fn detect_compiler(bytecode: &str) -> (&'static str, String) {
     // get a new logger
-    let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-    let (logger, _) = Logger::new(&level);
+    let logger = Logger::default();
 
     let mut compiler = "unknown";
     let mut version = "unknown".to_string();

common/src/ether/evm/ext/exec/mod.rs

@@ -42,8 +42,7 @@ impl VM {
         }
 
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger.debug_max(&format!("beginning symbolic execution for selector 0x{}", selector));
 
@@ -57,8 +56,7 @@ impl VM {
         let mut vm = self.clone();
 
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger.debug_max("beginning contract-wide symbolic execution");
 

common/src/ether/evm/ext/exec/util.rs

@@ -31,8 +31,7 @@ pub fn stack_contains_too_many_of_the_same_item(stack: &Stack) -> bool {
             16
     }) {
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger.debug_max(
             "jump matches loop-detection heuristic: 'stack_contains_too_many_of_the_same_item'",
@@ -49,8 +48,7 @@ pub fn stack_contains_too_many_of_the_same_item(stack: &Stack) -> bool {
 pub fn stack_item_source_depth_too_deep(stack: &Stack) -> bool {
     if stack.stack.iter().any(|frame| frame.operation.depth() > 16) {
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger
             .debug_max("jump matches loop-detection heuristic: 'stack_item_source_depth_too_deep'");
@@ -70,8 +68,7 @@ pub fn jump_condition_appears_recursive(stack_diff: &[StackFrame], jump_conditio
         .any(|solidified| jump_condition.contains(&solidified))
     {
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger
             .debug_max("jump matches loop-detection heuristic: 'jump_condition_appears_recursive'");
@@ -98,8 +95,7 @@ pub fn jump_condition_contains_mutated_memory_access(
         })
     }) {
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger.debug_max("jump matches loop-detection heuristic: 'jump_condition_contains_mutated_memory_access'");
         return true
@@ -125,8 +121,7 @@ pub fn jump_condition_contains_mutated_storage_access(
         })
     }) {
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger.debug_max("jump matches loop-detection heuristic: 'jump_condition_contains_mutated_storage_access'");
         return true
@@ -168,8 +163,7 @@ pub fn jump_condition_historical_diffs_approximately_equal(
     }
 
     // get a new logger
-    let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-    let (logger, _) = Logger::new(&level);
+    let logger = Logger::default();
     logger.debug_max("jump matches loop-detection heuristic: 'jump_condition_historical_diffs_approximately_equal'");
 
     true

common/src/ether/rpc.rs

@@ -17,8 +17,7 @@ use heimdall_cache::{read_cache, store_cache};
 /// `Result<u64, Box<dyn std::error::Error>>`
 pub async fn chain_id(rpc_url: &str) -> Result<u64, Box<dyn std::error::Error>> {
     // get a new logger
-    let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-    let (logger, _) = Logger::new(&level);
+    let logger = Logger::default();
 
     logger.debug_max(&format!("checking chain id for rpc url: '{}'", &rpc_url));
 
@@ -74,8 +73,7 @@ pub async fn get_code(
     rpc_url: &str,
 ) -> Result<String, Box<dyn std::error::Error>> {
     // get a new logger
-    let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-    let (logger, _) = Logger::new(&level);
+    let logger = Logger::default();
 
     // get chain_id
     let _chain_id = chain_id(rpc_url).await?;
@@ -145,8 +143,7 @@ pub async fn get_transaction(
     rpc_url: &str,
 ) -> Result<Transaction, Box<dyn std::error::Error>> {
     // get a new logger
-    let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-    let (logger, _) = Logger::new(&level);
+    let logger = Logger::default();
 
     logger.debug_max(&format!(
         "fetching calldata from node for transaction: '{}' .",

common/src/ether/selectors.rs

@@ -17,8 +17,7 @@ pub fn find_function_selectors(evm: &VM, assembly: &str) -> HashMap<String, u128
     let mut handled_selectors = HashSet::new();
 
     // get a new logger
-    let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-    let (logger, _) = Logger::new(&level);
+    let logger = Logger::default();
 
     // search through assembly for PUSHN (where N <= 4) instructions, optimistically assuming that
     // they are function selectors
@@ -109,8 +108,7 @@ pub async fn resolve_selectors<T>(selectors: Vec<String>) -> HashMap<String, Vec
 where
     T: ResolveSelector + Send + Clone + 'static, {
     // get a new logger
-    let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-    let (logger, _) = Logger::new(&level);
+    let logger = Logger::default();
 
     let resolved_functions: Arc<Mutex<HashMap<String, Vec<T>>>> =
         Arc::new(Mutex::new(HashMap::new()));

common/src/ether/signatures.rs

@@ -41,8 +41,7 @@ pub trait ResolveSelector {
 impl ResolveSelector for ResolvedError {
     async fn resolve(selector: &str) -> Option<Vec<Self>> {
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger.debug_max(&format!("resolving error selector {}", &selector));
 
@@ -125,8 +124,7 @@ impl ResolveSelector for ResolvedError {
 impl ResolveSelector for ResolvedLog {
     async fn resolve(selector: &str) -> Option<Vec<Self>> {
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger.debug_max(&format!("resolving event selector {}", &selector));
 
@@ -209,8 +207,7 @@ impl ResolveSelector for ResolvedLog {
 impl ResolveSelector for ResolvedFunction {
     async fn resolve(selector: &str) -> Option<Vec<Self>> {
         // get a new logger
-        let level = std::env::var("RUST_LOG").unwrap_or_else(|_| "INFO".into());
-        let (logger, _) = Logger::new(&level);
+        let logger = Logger::default();
 
         logger.debug_max(&format!("resolving event selector {}", &selector));