PSScriptAnalyzer fixes

JohnDuprey · Apr 16, 2023 · 63c8366 · 63c8366
1 parent 9abed01
commit 63c8366
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/DuoSecurity/Private/Base64/ConvertFrom-Base64.ps1 b/DuoSecurity/Private/Base64/ConvertFrom-Base64.ps1
@@ -8,10 +8,10 @@ function ConvertFrom-Base64 {
 
     .PARAMETER Base64
     File contents in Base64 string
-    
+
     .PARAMETER Path
     Path to the file
-    
+
     .EXAMPLE
     ConvertTo-Base64 -Path path/to/file.png
     #>

diff --git a/DuoSecurity/Public/Admin API/Custom Branding/Set-DuoCustomBranding.ps1 b/DuoSecurity/Public/Admin API/Custom Branding/Set-DuoCustomBranding.ps1
@@ -86,8 +86,7 @@ function Set-DuoCustomBranding {
                 if (Test-PngFile -Path $BackgroundImg) {
                     $BackgroundImg = ConvertTo-Base64 -Path $BackgroundImg
                 } else {
-                    Write-Error "$BackgroundImg is not a PNG file"
-                    return $false
+                    throw "$BackgroundImg is not a PNG file"
                 }
             }
             $Params.background_img = $BackgroundImg
@@ -100,8 +99,7 @@ function Set-DuoCustomBranding {
                 if (Test-PngFile -Path $Logo) {
                     $Logo = ConvertTo-Base64 -Path $Logo
                 } else {
-                    Write-Error "$Logo is not a PNG file"
-                    return $false
+                    throw "$Logo is not a PNG file"
                 }
             }
             $Params.background_img = $BackgroundImg

diff --git a/DuoSecurity/Public/Admin API/Phones/Send-DuoPhoneActivationSms.ps1 b/DuoSecurity/Public/Admin API/Phones/Send-DuoPhoneActivationSms.ps1
@@ -59,16 +59,14 @@ function Send-DuoPhoneActivationSms {
             $Params.install = $Install
             if ($InstallationMsg) {
                 if ($InstallationMsg -notmatch '<insturl>') {
-                    Write-Error 'Installation message must contain <insturl>'
-                    return $false
+                    throw 'Installation message must contain <insturl>'
                 }
                 $Params.installation_msg = $InstallationMsg
             }
         }
         if ($ActivationMsg) {
             if ($ActivationMsg -notmatch '<acturl>') {
-                Write-Error 'Activation message must contain <acturl>'
-                return $false
+                throw 'Activation message must contain <acturl>'
             }
             $Params.activation_msg = $ActivationMsg
         }

diff --git a/DuoSecurity/Public/Admin API/Phones/Send-DuoPhoneInstallationSms.ps1 b/DuoSecurity/Public/Admin API/Phones/Send-DuoPhoneInstallationSms.ps1
@@ -38,8 +38,7 @@ function Send-DuoPhoneInstallationSms {
         $Params = @{}
         if ($InstallationMsg) {
             if ($InstallationMsg -notmatch '<insturl>') {
-                Write-Error 'Installation message must contain <insturl>'
-                return $false
+                throw 'Installation message must contain <insturl>'
             }
             $Params.installation_msg = $InstallationMsg
         }