ysfx: report internal state change to daw (wip) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoepVanlier
force-pushed
the
undo_points
branch
from
e6d6038 to
e9e67c0
Compare
JoepVanlier
changed the title
notify the host when a script asks for an undo point to be made manually
JoepVanlier
force-pushed
the
undo_points
branch
from
e9e67c0 to
c7b6d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to save an undo history, but unfortunately this is complicated. The issue to work around is that most DAWs (e.g. ableton and bitwig) do not call
getStateInformation/setStateInformationwhen callingupdateHostDisplay(ChangeDetails().withNonParameterStateChanged(true)). This does work in REAPER though.You can get bitwig to store an undo point if you rename a parameter, but this is likely to cause bad issues down the road. Only changing a value seems insufficient.
It might be worth exploring exposing a fake parameter that basically triggers a
ysfx_save_statethat we store ourselves.