-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aot support 2.0 #75
base: aot
Are you sure you want to change the base?
Aot support 2.0 #75
Conversation
I have fixed the known bugs, including:
Limitations / Things that need to be disclaimed to end users:
Suggestions: In the future, the existing github workflow should be used to verify that jit and aot code paths still work on all supported platforms. The attached artifacts can be uploaded to nuget registry, too. It think that the workflow should be run for PRs and for new commits in main. The readme needs to be updated for aot. |
Hi @Jinjinov,
I have created this draft PR because I would like to get some early feedback.
What has been done so far:
I use the new workflow to verify that the nuget packages can be used on each support platform. I encountered some issues with target framework resolution, so this turned out to be a good approach.
I haven't created a
Hardware.Info.Aot.Test
but instead made the existingHardware.Info.Test
some sort of test runner that verifies expectations (architecture and jit/aot compiler) and then executes all hardware info queries as before.See this workflow run to see it in action: https://github.com/Gitii/Hardware.Info.Aot.Poc/actions/runs/11094018584/job/30821001822
I wanted to avoid code duplication and the same code should be executed in all six targets (win, linux, macos x jit, aot x x64).
Right now, there are some platform-dependant issues (see linked run) but I would like to check with you first, if the current approach is fine for you. Otherwise, I will refactor again and then iron out these "smaller" issues later.