Fix view-only ender chest (#278)

Fixes access permissions being checked against self
Jikoo · Jan 18, 2025 · 8a388b5 · 8a388b5
1 parent 206fff2
commit 8a388b5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/...1_R2/src/main/java/com/lishid/openinv/internal/v1_21_R2/container/menu/OpenChestMenu.java b/...1_R2/src/main/java/com/lishid/openinv/internal/v1_21_R2/container/menu/OpenChestMenu.java
@@ -124,10 +124,11 @@ protected OpenChestMenu(
   protected void preSlotSetup() {}
 
   protected @NotNull Slot getUpperSlot(int index, int x, int y) {
+    Slot slot = new Slot(container, index, x, y);
     if (viewOnly) {
-      return new SlotViewOnly(container, index, x, y);
+      return SlotViewOnly.wrap(slot);
     }
-    return new Slot(container, index, x, y);
+    return slot;
   }
 
 

diff --git a/...1_R3/src/main/java/com/lishid/openinv/internal/v1_21_R3/container/menu/OpenChestMenu.java b/...1_R3/src/main/java/com/lishid/openinv/internal/v1_21_R3/container/menu/OpenChestMenu.java
@@ -124,10 +124,11 @@ protected OpenChestMenu(
   protected void preSlotSetup() {}
 
   protected @NotNull Slot getUpperSlot(int index, int x, int y) {
+    Slot slot = new Slot(container, index, x, y);
     if (viewOnly) {
-      return new SlotViewOnly(container, index, x, y);
+      return SlotViewOnly.wrap(slot);
     }
-    return new Slot(container, index, x, y);
+    return slot;
   }
 
 

diff --git a/plugin/src/main/java/com/lishid/openinv/OpenInv.java b/plugin/src/main/java/com/lishid/openinv/OpenInv.java
@@ -256,7 +256,7 @@ public void setSilentContainerStatus(@NotNull final OfflinePlayer offline, final
         boolean viewOnly = edit != null && !edit.hasPermission(player);
 
         if (ownContainer || viewOnly && config.getAccessEqualMode() != AccessEqualMode.DENY) {
-            this.accessor.openInventory(player, inventory, viewOnly);
+            return this.accessor.openInventory(player, inventory, viewOnly);
         }
 
         for (int level = 4; level > 0; --level) {