Make the message subscription return an optional unsubscribe callback #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JichouP
approved these changes
Mar 30, 2024
|
@wewei Did it work correctly without changing the return type here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @JichouP , thanks for building this handy package to add TypeScript support for electron IPC. When I was using it, I find there's no way to unsubscribe a message from main. I propose this change to let the
on.xxxfunction return an optional callback, so that the renderer code can unsubscribe the message channel when it's no longer needed.I also made a small change in the build scripts, use
rimraf, which is cross platform, to replace the POSIX commandrm -rf. With this change, the package can be built on Windows.Feel free to comments, and I'll make changes accordingly.