Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call the listeners of PropertyKind.Renderer on render API fallback #1033

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Call the listeners of PropertyKind.Renderer on render API fallback #1033

merged 1 commit into from
Mar 10, 2025
+109 −103

Conversation

m-sasha
Copy link
Member

@m-sasha m-sasha commented Mar 8, 2025

Currently, these listeners are only called when the renderApi is set manually, not when it changes to a fallback.

@m-sasha m-sasha requested a review from igordmn March 8, 2025 12:34
MatkovIvan
MatkovIvan reviewed Mar 10, 2025
View reviewed changes
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it would be better to split the fix and cleaning/refactor, but it's not too big so LGTM.
Please wait for Igor's review before the merge

@m-sasha m-sasha merged commit 4462fe4 into master Mar 10, 2025
6 checks passed
@m-sasha m-sasha deleted the m-sasha/call-renderApi-change-listeners-on-fallback branch March 10, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatkovIvan MatkovIvan MatkovIvan left review comments

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-sasha @MatkovIvan @igordmn