Fix the background flashing when closing a window/dialog. #1032
Conversation
…552)" This reverts commit ac324c0. Flushing the transaction causes the window background to be visible for a frame when closing the window. https://youtrack.jetbrains.com/issue/CMP-5651
There was a problem hiding this comment.
Just for more context:
What CATransaction.flush does is committing all changes of CALayer properties and trees to be rendered to be visible during next frame.
CoreAnimation rendering is a blackbox so grouping transactions explicitly or implicitly is the only way to make multiple changes in the tree visually simultaneous.
Implicit transactions are always scoped within main runloop work items so this invocation here introduced a state barrier between before and after potentially allowing CoreAnimation to render two different frames with states from before and after the barrier, which is perceived as flickering.
In order to avoid flickering with guarantees we somehow need to ensure that both changes of CALayer hierarchy by AWT and us are confined within one transaction, which this PR is required for but doesn't guarantee as far as I see it.
|
@elijah-semyonov Thanks for the input. What I understood, but is clearly wrong, is that flushing the transaction is optional. I know it's wrong because removing the flush from other places in
It seems to me that in this particular instance, we're flushing a transaction that isn't our own (there's no |
|
As per doc flush always happens in the end of runloop work item. In other words, any job executed on the macOS executable main thread will be confined within implicit This API is not marked as |
Flushing the transaction causes the window background to be visible for a frame when closing the window.
Fixes: https://youtrack.jetbrains.com/issue/CMP-5651
This reverts #552. I have tested the IDE sample from Jewel, and that issue does not seem to reproduce anymore, even without flushing the transaction.
Screen.Recording.2025-03-04.at.12.07.24.mp4