Expose ICUs u_hasBinaryProperty #1029
Conversation
| internal fun Int.charCount(): Int = if (this >= MIN_SUPPLEMENTARY_CODE_POINT) 2 else 1 | ||
|
|
||
| internal val String.codePointsAsIntArray: IntArray | ||
| get() = codePoints.toList().toIntArray() |
There was a problem hiding this comment.
Doesn't it create an extra copy?
There was a problem hiding this comment.
It does (actually more than once, inside toList()), but it's not easy to avoid this copy, as the number of codepoints is not known upfront. And if we just return List<Int> here, the callers will still need to convert it to an int array.
| internal val String.codePoints | ||
| get() = codePointsAt(0) | ||
|
|
||
| internal fun String.codePointsAt(index: Int) = sequence { |
There was a problem hiding this comment.
The code in CharHelpers.skiko.kt mentioned is actually like:
| internal val String.codePoints | |
| get() = codePointsAt(0) | |
| internal fun String.codePointsAt(index: Int) = sequence { | |
| internal val CharSequence.codePoints get() = sequence { |
There was a problem hiding this comment.
Yes, the copy is after my changes in JetBrains/compose-multiplatform-core#1869
This is more generic and is not worse, so why change it?
There was a problem hiding this comment.
String/CharSequence consistency
There was a problem hiding this comment.
We have it in more than one place; the one I copied it from uses String, but sure, CharSequence is better.
| } | ||
|
|
||
| @Suppress("MemberVisibilityCanBePrivate", "unused", "SpellCheckingInspection") | ||
| object CharProperties { |
|
|
||
| @ExternalSymbolName("org_jetbrains_skia_icu_Unicode_nCodePointHasBinaryProperty") | ||
| @ModuleImport("./skiko.mjs", "org_jetbrains_skia_icu_Unicode_nCodePointHasBinaryProperty") | ||
| private external fun nCodePointHasBinaryProperty(codePoint: Int, property: Int): Boolean |
There was a problem hiding this comment.
Let's keep prefixes consistent (one way or another)
|
@m-sasha you forgot to push the changes, right? |
m-sasha
force-pushed
the
m-sasha/expose-icu-u_hasBinaryProperty
branch
from
fcddfc7 to
28f117d
Compare
Yes, sorry, pushed now. |
This is needed to detect emojis in Compose Multiplatform.
Also, it looks like the native implementations of
String.intCodePoints()were broken. I fixed them by copying the relevant code from Compose.