feat: add fixes from main

JetBrains-Research · Jun 12, 2023 · ae4bf9b · ae4bf9b
1 parent d7cf728
commit ae4bf9b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/core/src/main/kotlin/loader/gerrit/CommentsLoader.kt b/core/src/main/kotlin/loader/gerrit/CommentsLoader.kt
@@ -8,7 +8,7 @@ class CommentsLoader(files: Sequence<File>) {
   private val loadedComments = mutableListOf<MutableMap<Int, CommentsREST>>()
   private val commentsFilesIterator = CommentsFilesIterator(files)
 
-  fun get(id: Int): CommentsREST {
+  fun get(id: Int): CommentsREST? {
     val iteratorLoadedComments = loadedComments.iterator()
     while (iteratorLoadedComments.hasNext()) {
       val loaded = iteratorLoadedComments.next()
@@ -25,7 +25,7 @@ class CommentsLoader(files: Sequence<File>) {
       value?.let { return it }
     }
 
-    throw Exception("There is no comments for id:${id}")
+    return null
   }
 
 }
diff --git a/core/src/main/kotlin/loader/gerrit/LoaderChanges.kt b/core/src/main/kotlin/loader/gerrit/LoaderChanges.kt
@@ -209,7 +209,7 @@ class LoaderChanges(
         changeIds.add(changeId)
 
         val comments = commentsLoader.get(changeId)
-        if (change.totalCommentCount > 0) throw Exception("Can't find comments for ${change.number}")
+        if (change.totalCommentCount > 0 && comments == null) logger.severe("Can't find comments for ${change.number}")
         processChanges(change, comments)
       }
       logger.info("Finished changes from ${file.name} file")

diff --git a/core/src/main/kotlin/loader/gerrit/iterators/FilesListIterator.kt b/core/src/main/kotlin/loader/gerrit/iterators/FilesListIterator.kt
@@ -36,11 +36,13 @@ open class FilesListIterator<T>(
   }
 
   private fun resetIterators() {
-    if (filesIter.hasNext()) {
+    while (filesIter.hasNext()) {
       val listOfList = filesIter.next()
-      // assume files not empty
+      if (listOfList.isEmpty()) continue
+
       listIter = listOfList.iterator()
       resetValueIterator()
+      return
     }
   }