Skip to content

Commit

Permalink
add embed_id
Browse files Browse the repository at this point in the history
  • Loading branch information
Javan-Odhiambo committed Jun 6, 2024
1 parent 28b6688 commit c4c9d58
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/app/dashboard/innovation/[id]/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const InnovationDetailPage = ({ params }: InnovationDetailPageProps) => {

container && embedDashboard({
// TODO: Add embed ID
id: dashboardId, // given by the Superset embedding UI
id: innovation?.embed_id, // given by the Superset embedding UI
supersetDomain: supersetUrl,
mountPoint: container, // html element in which iframe render
fetchGuestToken: () => fetchGuestTokenFromBackend(),
Expand Down
3 changes: 2 additions & 1 deletion src/lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ interface TInnovation {
dashboard_link: string;
dashboard_image: string;
dashboard_definitions: string;
dashboard_id: string;
// dashboard_id: string;
// banner_image: string;
comments_number: number;
likes_number: number;
Expand All @@ -24,6 +24,7 @@ interface TInnovation {
is_bookmarked: boolean;
status: string;
dashboard_type: string;
embed_id: string;
// category: string;
}

Expand Down

0 comments on commit c4c9d58

Please sign in to comment.