Add AdvancedSql.StreamAsync<>() #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to IAdvancedSql interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's now a new interface on IAdvancedSql that wraps all advanced sql query methods and adds new methods to stream the results via IAsyncEnumrable.
The old AdvancedSql*-methods are marked as obsolete and delegate to the new methods.
The new AdavancedSql methods are implemented as explicit interface implementations on the QuerySession class as a separate partial class. The alternative would be to make IQuerySession.Advanced return a separate implementation of IAdvancedSql. Let me know, if you prefer this and I will change the PR.