using snake case instead of kebab casing for derived column names w/ …

…flat projections. Closes GH-2778
JasperFx · Nov 30, 2023 · 497dde1 · 497dde1
1 parent 282e19c
commit 497dde1
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 5 deletions.
diff --git a/docs/events/projections/flat.md b/docs/events/projections/flat.md
@@ -26,7 +26,7 @@ public record ImportFinished(DateTimeOffset Finished);
 
 public record ImportFailed;
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten.Testing/Examples/FlatTableProjection.cs#L9-L26' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_flat_table_events' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten.Testing/Examples/FlatTableProjection.cs#L12-L29' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_flat_table_events' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 At some point, we’re going to want to apply some metrics to the execution history to understand the average size of the 
@@ -80,7 +80,7 @@ public class ImportSqlProjection: EventProjection
     }
 }
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten.Testing/Examples/FlatTableProjection.cs#L30-L72' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_import_sql_projection' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten.Testing/Examples/FlatTableProjection.cs#L33-L75' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_import_sql_projection' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 A couple notes about the code above:
@@ -156,7 +156,7 @@ public class FlatImportProjection: FlatTableProjection
     }
 }
 ```
-<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten.Testing/Examples/FlatTableProjection.cs#L76-L129' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_flat_import_projection' title='Start of snippet'>anchor</a></sup>
+<sup><a href='https://github.com/JasperFx/marten/blob/master/src/Marten.Testing/Examples/FlatTableProjection.cs#L88-L141' title='Snippet source file'>snippet source</a> | <a href='#snippet-sample_flat_import_projection' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 A couple notes on this version of the code:

diff --git a/src/Marten.Testing/Examples/FlatTableProjection.cs b/src/Marten.Testing/Examples/FlatTableProjection.cs
@@ -2,7 +2,10 @@
 using Marten.Events;
 using Marten.Events.Projections;
 using Marten.Events.Projections.Flattened;
+using Marten.Util;
+using Shouldly;
 using Weasel.Postgresql.Tables;
+using Xunit;
 
 namespace Marten.Testing.Examples;
 
@@ -72,6 +75,15 @@ public void Project(IEvent<ImportFailed> e, IDocumentOperations ops)
 #endregion
 
 
+public class KebabNamingTests
+{
+    [Fact]
+    public void get_the_name_with_underscores()
+    {
+        "ActivityType".ToSnakeCase().ShouldBe("activity_type");
+    }
+}
+
 
 #region sample_flat_import_projection
 
@@ -89,7 +101,7 @@ public FlatImportProjection() : base("import_history", SchemaNameSource.EventSch
         Project<ImportStarted>(map =>
         {
             // Set values in the table from the event
-            map.Map(x => x.ActivityType).NotNull();
+            map.Map(x => x.ActivityType);
             map.Map(x => x.CustomerId);
             map.Map(x => x.PlannedSteps, "total_steps")
                 .DefaultValue(0);

diff --git a/src/Marten/Events/Projections/Flattened/MemberMap.cs b/src/Marten/Events/Projections/Flattened/MemberMap.cs
@@ -5,6 +5,7 @@
 using JasperFx.CodeGeneration.Model;
 using JasperFx.Core;
 using Marten.Linq.Parsing;
+using Marten.Util;
 using Weasel.Postgresql.Tables;
 
 namespace Marten.Events.Projections.Flattened;
@@ -21,7 +22,7 @@ public MemberMap(Expression<Func<TEvent, TMember>> members, string? tableColumn,
         _members = MemberFinder.Determine(members);
         _mapType = columnMapType;
 
-        ColumnName = tableColumn ?? _members.Select(x => x.Name.ToKebabCase()).Join("_");
+        ColumnName = tableColumn ?? _members.Select(x => x.Name.ToSnakeCase()).Join("_");
     }
 
     public string ColumnName { get; }