Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tablestore from Alicloud as the new storage backend #4721

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Merge pull request #1 from zhanghaochenFCB/master

a07508b
Select commit
Loading
Failed to load commit list.
Open

Add support for Tablestore from Alicloud as the new storage backend #4721

Merge pull request #1 from zhanghaochenFCB/master
a07508b
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis succeeded Nov 6, 2024 in 0s

Your pull request is up to standards!

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 14
           

Complexity increasing per file
==============================
- janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreGraphConcurrentTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManagerConfigTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreGraphTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/blueprints/TableStoreMultiQueryGraphProvider.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreLuceneCustomIdTest.java  2
- janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreMultiWriteStoreTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/hadoop/TableStoreInputFormatIT.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreOperationCountingTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/hadoop/TableStoreIndexManagementIT.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManagerMutationTest.java  13
- janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreCustomIdTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStorePartitionGraphTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreDistributedStoreManagerTest.java  1
- janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreKeyColumnValueStore.java  13
- janusgraph-tablestore/src/test/java/org/janusgraph/hadoop/TableStoreSnapshotInputFormatIT.java  4
- janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreIDAuthorityTest.java  1
- janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java  17
- janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreTransaction.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/TableStoreContainer.java  4
- janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/blueprints/TableStoreGraphComputerProvider.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreLogTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/hadoop/TableStoreCustomIdSparkTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreLockStoreTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreOLAPTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/blueprints/TableStoreGraphProvider.java  4
- janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreGraphPerformanceMemoryTest.java  1
         

Clones added
============
- janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreGraphTest.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManagerMutationTest.java  2
- janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreKeyColumnValueStore.java  1
- janusgraph-tablestore/src/test/java/org/janusgraph/hadoop/TableStoreSnapshotInputFormatIT.java  16
- janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java  9
- janusgraph-tablestore/src/test/java/org/janusgraph/TableStoreContainer.java  2
- janusgraph-tablestore/src/test/java/org/janusgraph/blueprints/TableStoreGraphProvider.java  1

See the complete overview on Codacy

Annotations

Check notice on line 20 in janusgraph-tablestore/docker/Dockerfile

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/docker/Dockerfile#L20 

Avoid additional packages by specifying `--no-install-recommends`

Check warning on line 20 in janusgraph-tablestore/docker/Dockerfile

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/docker/Dockerfile#L20 

Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`

Check notice on line 41 in janusgraph-tablestore/docker/Dockerfile

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/docker/Dockerfile#L41 

Delete the apt-get lists after installing something

Check notice on line 110 in janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreKeyColumnValueStore.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreKeyColumnValueStore.java#L110 

Document empty method body

Check warning on line 231 in janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java#L231 

The constructor 'TableStoreStoreManager(org.janusgraph.diskstorage.configuration.Configuration)' has an NPath complexity of 2304, current threshold is 200

Check notice on line 231 in janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java#L231 

Unnecessary use of fully qualified name 'org.janusgraph.diskstorage.configuration.Configuration' due to existing import 'org.janusgraph.diskstorage.configuration.Configuration'

Check warning on line 340 in janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java#L340 

Avoid throwing raw exception types.

Check warning on line 538 in janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java#L538 

Avoid unused private methods such as 'getRegionLocations(TableName)'.

Check warning on line 588 in janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java#L588 

Avoid unused private methods such as 'normalizeKeyBounds(List)'.

Check warning on line 810 in janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/main/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManager.java#L810 

The method 'convertToCommands(Map, Long, Long)' has an NPath complexity of 296, current threshold is 200

Check warning on line 57 in janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManagerMutationTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/test/java/org/janusgraph/diskstorage/tablestore/TableStoreStoreManagerMutationTest.java#L57 

Use one line for each declaration, it enhances code readability.

Check notice on line 45 in janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreGraphTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreGraphTest.java#L45 

Document empty method body

Check notice on line 48 in janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreGraphTest.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/test/java/org/janusgraph/graphdb/tablestore/TableStoreGraphTest.java#L48 

Document empty method body

Check notice on line 60 in janusgraph-tablestore/src/test/java/org/janusgraph/hadoop/TableStoreSnapshotInputFormatIT.java

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

janusgraph-tablestore/src/test/java/org/janusgraph/hadoop/TableStoreSnapshotInputFormatIT.java#L60 

The class name 'TableStoreSnapshotInputFormatIT' doesn't match '^Test.*$|^[A-Z][a-zA-Z0-9]*Test(s|Case)?$'
View more details on Codacy Production