Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-api): SAML TR metadata validation, user mgt spec for error and security issue #7930

Merged
merged 36 commits into from
Mar 1, 2024

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Mar 1, 2024

Prepare


Description

  1. security issue fix: Upgraded version of org.apache.james:apache-mime4j-core from 0.8.9 to 0.8.10 as per [security-report] (https://artifacthub.io/packages/helm/janssen-auth-server/janssen?modal=security-report)
  2. Issue#7874: kc-saml-plugin - changes to accept only FILE and MANUAL as SPMetaDataSourceType and corresponding validation.
  3. Issue#7913: user-mgt-plugin: Added Error response object in Swagger Spec

Target issue

closes #7874 #7913

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs pujavs requested review from yuriyz and yurem as code owners March 1, 2024 18:45
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Mar 1, 2024
@pujavs pujavs requested a review from devrimyatar March 1, 2024 18:47
@yuriyz yuriyz enabled auto-merge (squash) March 1, 2024 19:15
@yuriyz yuriyz merged commit b22b0a4 into main Mar 1, 2024
2 checks passed
@yuriyz yuriyz deleted the jans-config-api-issues branch March 1, 2024 19:15
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'Jans-Keycloak-Link'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 1, 2024

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'SCIM API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed for 'Fido2 API'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

yuriyz added a commit that referenced this pull request Nov 7, 2024
… and security issue (#7930)

* feat(config-api): saml plugin changes for new fields

Signed-off-by: pujavs <[email protected]>

* feat(config-api): kc link plugin endpoint

Signed-off-by: pujavs <[email protected]>

* feat(config-api): kc link plugin endpoint

Signed-off-by: pujavs <[email protected]>

* feat(config-api): kc link plugin endpoint

Signed-off-by: pujavs <[email protected]>

* feat(config-api): saml plugin changes

Signed-off-by: pujavs <[email protected]>

* feat(config-api): kc plugin changes

Signed-off-by: pujavs <[email protected]>

* feat(config-api): saml plugin changes for metadata elements

Signed-off-by: pujavs <[email protected]>

* feat(config-api): resolved merge conflict

Signed-off-by: pujavs <[email protected]>

* feat(config-api): resolved merge conflict

Signed-off-by: pujavs <[email protected]>

* feat(config-api): saml metedata elements save

Signed-off-by: pujavs <[email protected]>

* feat(config-api): attribute validation check

Signed-off-by: pujavs <[email protected]>

* feat(config-api): attribute validation in schema

Signed-off-by: pujavs <[email protected]>

* feat(config-api): custom attribute verification in schema

Signed-off-by: pujavs <[email protected]>

* feat(config-api): attribute check in schema name and client password decryption handling

Signed-off-by: pujavs <[email protected]>

* feat(config-api): saml plugin changes for sp metadata handling

Signed-off-by: pujavs <[email protected]>

* feat(config-api): saml plugin changes for sp metadata handling

Signed-off-by: pujavs <[email protected]>

* feat(config-api): SAML TR enhacement for metadata field and filename

Signed-off-by: pujavs <[email protected]>

* feat(config-api): SAML TR enhacement for metadata field and filename

Signed-off-by: pujavs <[email protected]>

* feat(config-api): security issue for apache-mime4j-core

Signed-off-by: pujavs <[email protected]>

* feat(config-api): exception handling for user creation

Signed-off-by: pujavs <[email protected]>

* fix(config-api): SAML TR metadata validation, user mgt spec for error and security issue

Signed-off-by: pujavs <[email protected]>

* fix(config-api): SAML TR metadata validation, user mgt spec for error and security issue

Signed-off-by: pujavs <[email protected]>

---------

Signed-off-by: pujavs <[email protected]>
Co-authored-by: YuriyZ <[email protected]>
Former-commit-id: b22b0a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(jans-config-api): TrustRelationship API does not properly store file name of metadata files
4 participants