Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-cedarling): implement environment variable loading for sidecar #10751

Merged
merged 11 commits into from
Jan 28, 2025

Conversation

SafinWasi
Copy link
Contributor

Prepare


Description

Target issue

closes #10732 and closes #10691

Implementation Details


Test and Document the changes

N/A

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@mo-auto mo-auto added area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request labels Jan 27, 2025
@SafinWasi SafinWasi marked this pull request as ready for review January 28, 2025 15:09
@SafinWasi SafinWasi requested review from moabu and olehbozhok January 28, 2025 15:09
moabu
moabu previously approved these changes Jan 28, 2025
olehbozhok
olehbozhok previously approved these changes Jan 28, 2025
Copy link
Contributor

@olehbozhok olehbozhok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

jans-cedarling/flask-sidecar/README.md Show resolved Hide resolved
@moabu moabu dismissed stale reviews from olehbozhok and themself via a02de10 January 28, 2025 16:06
@moabu moabu merged commit 21d8ef5 into main Jan 28, 2025
8 checks passed
@moabu moabu deleted the feat-jans-cedarling-10732 branch January 28, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-documentation Documentation needs to change as part of issue or PR comp-jans-cedarling Touching folder /jans-cedarling kind-feature Issue or PR is a new feature request
Projects
None yet
4 participants