rename Group and Groupattrs to MultiscaleGroup and MultiscaleGroupAttrs
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are failing because CI uses a later numcodecs release than I am using for local development, and that version of numcodecs has changed the JSON serialization of the zstd codec, which makes the doctests fail. I am merging anyway, since these test failures are not significant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses concerns raised in #36. Renames
GroupandGroupattrstoMultiscaleGroupandMultiscaleGroupAttrs. Deprecated classes with the old names still exist, to support backwards compatibility.Tests are failing because this project still supports python 3.9, which has been widely dropped. A separate PR will drop python 3.9.