Admin DB Cleanup for TmWorkspaces #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krokicki
approved these changes
Mar 4, 2025
| @@ -13,6 +13,7 @@ | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| import com.google.common.collect.ImmutableList; | |||
| import com.mongodb.WriteConcern; | |||
There was a problem hiding this comment.
Oh, I just forgot to remove because I was trying to optimize the speed of the bulk delete. In the end it didn't add any speed. I can remove this unused import
| // Step 1: Get all accessible workspaces using existing method | ||
| List<TmWorkspace> workspaces = getAllTmWorkspaces(subjectKey); | ||
|
|
||
| List<TmWorkspaceInfo> workspaceInfoList = new ArrayList<>(); |
There was a problem hiding this comment.
Why is this new model necessary? Why not just return the TmWorkspace objects themselves? That would make this method more generally usable, and it wouldn't require expanding the model.
There was a problem hiding this comment.
I'm calculating the bson size of the workspace by totaling all the document size of the associated neurons. I could add this size to the TmWorkspace, but since it's dynamically calculated doesn't make sense to be persisted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This are model changes for a new admin functionin the GUI for cleaning up large TmWorkspaces. It first searches through the database to return the largest workspaces, then allows the user to select the workspaces for removal. It also fixes an issue with workspace deletion to target the actual neuron collection where the workspace's neurons were stored.
This is intended for admins of HortaCloud to clean up their Mongo database by removing large fragment workspaces that might be taking a lot of memory on disk.