-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not longer required extension and fix handling of willImplement and willExtend #369
Remove not longer required extension and fix handling of willImplement and willExtend #369
Conversation
@ondrejmirtes do you know when you will release the 2.1.5 version, as this release is a blocker for merging this PR (due to the min version in the new requirement) ? |
I just wanted to demonstrate that it works, I think this PR is better overall #367 and does the same thing. As a rule of thumb the next PHPStan release always a few days away at max :) |
PHPStan 2.1.5 is out https://github.com/phpstan/phpstan/releases/tag/2.1.5 |
a0fb329
to
e252058
Compare
I don't see PHPStan ^2.1.5 required in composer.json here in master. |
@ondrejmirtes @stof thank you both here for you support. Tagged a new version |
@alexander-schranz I believe PHPStan ^2.1.5 should be required in composer.json. |
@ondrejmirtes you are right removed the false line when solving the merge conflicts 🙈 : fixed in #376 |
With this fix in PHPStan itself, the willExtend/willImplement method PHPDocs are sufficient for correct understanding: phpstan/phpstan-src@dab99cb