Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not longer required extension and fix handling of willImplement and willExtend #369

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

ondrejmirtes
Copy link
Contributor

With this fix in PHPStan itself, the willExtend/willImplement method PHPDocs are sufficient for correct understanding: phpstan/phpstan-src@dab99cb

@stof
Copy link
Contributor

stof commented Feb 11, 2025

@ondrejmirtes do you know when you will release the 2.1.5 version, as this release is a blocker for merging this PR (due to the min version in the new requirement) ?

@ondrejmirtes
Copy link
Contributor Author

I just wanted to demonstrate that it works, I think this PR is better overall #367 and does the same thing.

As a rule of thumb the next PHPStan release always a few days away at max :)

@alexander-schranz
Copy link
Collaborator

Nice, thank you 👍 ,

I also tested the additional cases from #366 in #370 and it seems also there work as expected.

@ondrejmirtes
Copy link
Contributor Author

PHPStan 2.1.5 is out https://github.com/phpstan/phpstan/releases/tag/2.1.5

@alexander-schranz alexander-schranz changed the base branch from bugfix/will-implement to master February 13, 2025 13:22
@alexander-schranz alexander-schranz merged commit 9cb6e2a into Jan0707:master Feb 13, 2025
12 of 13 checks passed
@alexander-schranz alexander-schranz changed the title Extension not needed anymore Remove not longer required extension and fix handling of willImplement and willExtend Feb 13, 2025
@ondrejmirtes
Copy link
Contributor Author

I don't see PHPStan ^2.1.5 required in composer.json here in master.

@alexander-schranz
Copy link
Collaborator

@ondrejmirtes @stof thank you both here for you support. Tagged a new version 2.1.0.

@ondrejmirtes
Copy link
Contributor Author

@alexander-schranz I believe PHPStan ^2.1.5 should be required in composer.json.

@alexander-schranz
Copy link
Collaborator

@ondrejmirtes you are right removed the false line when solving the merge conflicts 🙈 : fixed in #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants