Feature/483 lav aktiviteter offentlige account login (CodingPirates#690)

* issue CodingPirates#663: Refactor: rework on activities test * Refactor: put login into test_functions * Refactor: Taking out account_create from entry_page * Restructuring front page, login page, account creation page * Redesign: Navigation buttons * Update package-lock.json * Added .nvmrc to ensure using identical node version
JakobLibak · Sep 2, 2021 · ef23dc1 · ef23dc1
1 parent b55e0c0
commit ef23dc1
Show file tree

Hide file tree

Showing 20 changed files with 404 additions and 423 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+v10.19.0
diff --git a/members/forms/signup_form.py b/members/forms/signup_form.py
@@ -11,7 +11,7 @@ def __init__(self, *args, **kwargs):
         super(signupForm, self).__init__(*args, **kwargs)
         self.helper = FormHelper()
         self.helper.form_method = "post"
-        self.helper.form_action = "entry_page"
+        self.helper.form_action = "account_create"
         self.helper.html5_required = True
         self.helper.layout = Layout(
             Hidden("form_id", "signup", id="id_form_id"),

diff --git a/members/static/members/sass/account_create.scss b/members/static/members/sass/account_create.scss
@@ -0,0 +1,10 @@
+@use "definitions";
+@use "buttons";
+
+
+#signup-form {
+    border: 1px solid rgba(0, 0, 0, 0.125);
+    padding: 1.25rem;
+    background-clip: border-box;
+    border-radius: 0.25rem;
+}
diff --git a/members/static/members/sass/entry_page.scss b/members/static/members/sass/entry_page.scss
@@ -47,10 +47,3 @@
         }
     }
 }
-
-#signup-form {
-    border: 1px solid rgba(0, 0, 0, 0.125);
-    padding: 1.25rem;
-    background-clip: border-box;
-    border-radius: 0.25rem;
-}
diff --git a/members/static/members/sass/header.scss b/members/static/members/sass/header.scss
@@ -36,10 +36,10 @@ nav {
             text-align: center !important;
         }
     }
-}
-#login-logout {
-    text-align: right;
-    flex-grow: 2;
+    > .account-sep {
+        text-align: right;
+        flex-grow: 2;
+    }
 }
 
 .inactive {

diff --git a/members/templates/members/account_create.html b/members/templates/members/account_create.html
@@ -0,0 +1,12 @@
+{% extends 'members/base.html' %} {% load crispy_forms_tags %} {% load static %}
+{% block content %}
+
+  <h1>Tilmelding til Coding Pirates</h1>
+  <p>
+    Indtast barnets og forældrenes informationer, for at tilmelde en Coding
+    Pirates-workshop, eller for at komme med på ventelisten.
+  </p>
+  <div id="signup-form">
+      {% crispy signupform %}
+  </div>
+{% endblock %}
diff --git a/members/templates/members/entry_page.html b/members/templates/members/entry_page.html
@@ -1,18 +1,7 @@
 {% extends 'members/base.html' %} {% load crispy_forms_tags %} {% load static %}
 {% block content %}
 
-{% if user.is_authenticated %}
   <div id="user-action-container">
-    <div>
-      <span><i class="fa-users fa fa-4x"></i></span>
-      <div>
-        <h4>Jeres familie</h4>
-        <a href="{% url 'family_detail' %}">
-          Se familie <i class="fa fa-long-arrow-alt-right"></i>
-        </a>
-          <p>Se og ret stamdata for din familie</p>
-      </div>
-    </div>
     <div>
       <span><i class="fa-list-ol fa fa-4x"></i></span>
       <div>
@@ -21,7 +10,7 @@ <h4>Opskriv til afdelinger</h4>
           Afdelinger <i class="fa fa-long-arrow-alt-right"></i>
         </a>
         <p>
-          Her kan du opskrive dig som interesseret til en af vores 
+          Her kan du opskrive dig som interesseret til en af vores
           afdelinger til næste gang vi starter nye hold op
         </p>
       </div>
@@ -65,14 +54,4 @@ <h4>Bliv støttemedlem</h4>
     <a href="mailto:[email protected]">[email protected]</a>.
   </p>
 
-{% else %}
-  <h1>Tilmelding til Coding Pirates</h1>
-  <p>
-    Indtast barnets og forældrenes informationer, for at tilmelde en Coding
-    Pirates-workshop, eller for at komme med på ventelisten.
-  </p>
-  <div id="signup-form">
-      {% crispy signupform %}
-  </div>
-{% endif %}
 {% endblock %}
diff --git a/members/templates/members/header.html b/members/templates/members/header.html
@@ -3,16 +3,17 @@
     <a id="toggle" class="active" href="#" onClick="toggleNav()">
         <i class="fa fa-bars fa-2x"></i>
     </a>
+    <a href="{% url "entry_page" %}">Oversigt</a>
+    <a href="{% url "department_signup" %}">Afdelinger</a>
+    <a href="{% url "activities" %}">Arrangementer</a>
+    <a href="{% url "membership" %}">Medlemskaber</a>
+    <a href="{% url "support_membership" %}">Støttemedlemskaber</a>
+    <div class="account-sep"></div>
     {% if user.is_authenticated %}
-        <a href="{% url "entry_page" %}">Oversigt</a>
         <a href="{% url "family_detail" %}">Familie</a>
-        <a href="{% url "department_signup" %}">Afdelinger</a>
-        <a href="{% url "activities" %}">Arrangementer</a>
-        <a href="{% url "membership" %}">Medlemskaber</a>
-        <a href="{% url "support_membership" %}">Støttemedlemskaber</a>
         <a id="login-logout" href="{% url 'person_logout' %}">Log ud</a>
     {% else %}
-        <a href="{% url "entry_page" %}">Tilmeld barn</a>
+        <a href="{% url "account_create" %}">Tilmeld barn</a>
         <a href="{% url "volunteer_signup" %}">Bliv frivillig</a>
         <a id="login-logout" href="{% url 'person_login' %}">Log ind</a>
     {% endif %}

diff --git a/members/templates/members/login.html b/members/templates/members/login.html
@@ -30,6 +30,18 @@
                 </div>
             </div>
         </div>
+        <div class="row center">
+            <div class="loginBox col-lg-6 col-md-7 col-sm-8 col-11 ">
+                <div class="loginTitle"><span>Opret bruger</span></div>
+                    <a href="{% url 'account_create' %}" title="Tilmeld barn" class="button-primary-color block-button">
+                        Tilmeld barn
+                    </a>
+                    <a href="{% url 'volunteer_signup' %}" title="Bliv frivillig" class="button-primary-color block-button">
+                        Bliv frivillig
+                    </a>
+                </div>
+            </div>
+        </div>
     </form>
 </div>
 {% endblock %}
diff --git a/...sts/test_functional/test_create_family.py → ...ts/test_functional/test_account_create.py b/...sts/test_functional/test_create_family.py → ...ts/test_functional/test_account_create.py
@@ -16,7 +16,7 @@
 """
 
 
-class SignUpTest(StaticLiveServerTestCase):
+class AccountCreateTest(StaticLiveServerTestCase):
     host = socket.gethostbyname(socket.gethostname())
     serialized_rollback = True
 
@@ -32,9 +32,9 @@ def tearDown(self):
         self.browser.save_screenshot("test-screens/sign_up_screen_final.png")
         self.browser.quit()
 
-    def test_entry_page(self):
+    def test_account_create(self):
         # Loads the front page
-        self.browser.get(self.live_server_url)
+        self.browser.get(f"{self.live_server_url}/account/create")
         self.assertEqual("Coding Pirates Medlemssystem", self.browser.title)
         self.browser.save_screenshot("test-screens/sign_up_screen_1.png")
 
@@ -96,8 +96,5 @@ def test_entry_page(self):
 
         self.browser.find_element_by_xpath("//input[@type='submit']").click()
 
-        # Check that we were redirectet to overview page
-        elements = self.browser.find_elements_by_xpath(
-            "//*[text()[contains(.,'For yderligere hjælp med at bruge denne side')]]"
-        )
-        self.assertGreater(len(elements), 0)
+        # Check that we were redirectet to front page
+        self.assertEqual(f"{self.live_server_url}/", self.browser.current_url)
diff --git a/members/tests/test_functional/test_account_login.py b/members/tests/test_functional/test_account_login.py
@@ -0,0 +1,56 @@
+import os
+import socket
+
+from django.contrib.staticfiles.testing import StaticLiveServerTestCase
+from selenium import webdriver
+from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+
+from members.tests.factories import (
+    MemberFactory,
+)
+
+"""
+This test goes to the account login page
+"""
+
+
+class AccountLoginTest(StaticLiveServerTestCase):
+    host = socket.gethostbyname(socket.gethostname())
+    serialized_rollback = True
+
+    def setUp(self):
+        self.member = MemberFactory.create()
+
+        self.browser = webdriver.Remote(
+            "http://selenium:4444/wd/hub", DesiredCapabilities.CHROME
+        )
+
+    def tearDown(self):
+        if not os.path.exists("test-screens"):
+            os.mkdir("test-screens")
+        self.browser.save_screenshot("test-screens/activities_list_final.png")
+        self.browser.quit()
+
+    def test_account_login(self):
+        self.browser.get(f"{self.live_server_url}/account/login")
+        self.assertIn(
+            "Log ind",
+            [
+                e.text
+                for e in self.browser.find_elements_by_xpath(
+                    "//body/descendant-or-self::*"
+                )
+            ],
+        )
+        self.browser.find_element_by_link_text("Log ind")
+        self.assertIn(
+            "Opret bruger",
+            [
+                e.text
+                for e in self.browser.find_elements_by_xpath(
+                    "//body/descendant-or-self::*"
+                )
+            ],
+        )
+        self.browser.find_element_by_link_text("Tilmeld barn")
+        self.browser.find_element_by_link_text("Bliv frivillig")