Fixed some Clang Tools analyzer warnings

JairajJangle · Jul 3, 2020 · ec06254 · ec06254
1 parent 57e1077
commit ec06254
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 15 deletions.
diff --git a/CustomWidgets/ChainMenuWidget/chainmenuwidget.cpp b/CustomWidgets/ChainMenuWidget/chainmenuwidget.cpp
@@ -31,7 +31,7 @@ ChainMenuWidget::ChainMenuWidget(QWidget *parent) :
 
     ui->verticalLayout_2->setAlignment(Qt::AlignCenter);
 
-    for(auto key : chainMenuOpMap.keys())
+    for(int &key : chainMenuOpMap.keys())
     {
         ui->comboBox->addItem(chainMenuOpMap.value(key), key);
     }

diff --git a/CustomWidgets/focusawarelineedit.cpp b/CustomWidgets/focusawarelineedit.cpp
@@ -30,11 +30,11 @@ FocusAwareLineEdit::~FocusAwareLineEdit()
 void FocusAwareLineEdit::focusInEvent(QFocusEvent *e)
 {
     QLineEdit::focusInEvent(e);
-    emit(focussed(true));
+    emit focussed(true);
 }
 
 void FocusAwareLineEdit::focusOutEvent(QFocusEvent *e)
 {
     QLineEdit::focusOutEvent(e);
-    emit(focussed(false));
+    emit focussed(false);
 }
diff --git a/OpenCVFunction/backgroundsubtract.h b/OpenCVFunction/backgroundsubtract.h
@@ -160,7 +160,7 @@ private slots:
                 this, SLOT(resetChangesClicked()));
 
         learningRateEditLayout->lineEdit->setValidator(
-                    new QRegExpValidator(RegExps::regEx0_1Decimal));
+                    new QRegExpValidator(QRegExp(RegExps::regEx0_1Decimal)));
 
         pKNN = cv::createBackgroundSubtractorKNN(1,2000.0,false); //int history=500, double dist2Threshold=400.0, bool detectShadows=true
         pMOG =  cv::bgsegm::createBackgroundSubtractorMOG();

diff --git a/Utils/constants.h b/Utils/constants.h
@@ -25,16 +25,16 @@
 #include <QRegExp>
 
 namespace Info {
-const QString appName = "OpenCV Catalogue";
-const QString version = "v0.2.1";
+static const char* appName = "OpenCV Catalogue";
+static const char* version = "v0.2.1";
 }
 
 namespace RegExps {
-const QRegExp regEx0_1Decimal = QRegExp("^(0(\\.[0-9]{1,4})?|1(\\.0{1,4})?)$");
+static const char* regEx0_1Decimal = "^(0(\\.[0-9]{1,4})?|1(\\.0{1,4})?)$";
 }
 
 namespace Strings {
-const QString noOperationSelected = "No operation Selected";
+static const char* noOperationSelected = "No operation Selected";
 }
 
 #endif // CONSTANTS_H
diff --git a/Window/MainWindow/mainwindow.cpp b/Window/MainWindow/mainwindow.cpp
@@ -264,18 +264,18 @@ void MainWindow::refreshOperationWidgets()
         if(vBoxSub->count() > 1)
         {
             dynamic_cast<ChainMenuWidget*>(vBoxSub->itemAt(vBoxSub->count() - 2)->
-                                          widget())->setLineVisibility(true);
+                                           widget())->setLineVisibility(true);
             dynamic_cast<ChainMenuWidget*>(vBoxSub->itemAt(vBoxSub->count() - 2)->
-                                          widget())->setEnabled(false);
+                                           widget())->setEnabled(false);
             dynamic_cast<ChainMenuWidget*>(vBoxSub->itemAt(vBoxSub->count() - 1)->
-                                          widget())->setEnabled(true);
+                                           widget())->setEnabled(true);
         }
         else if(vBoxSub->count() == 1)
         {
             dynamic_cast<ChainMenuWidget*>(vBoxSub->itemAt(vBoxSub->count() - 1)->
-                                          widget())->setEnabled(true);
+                                           widget())->setEnabled(true);
             dynamic_cast<ChainMenuWidget*>(vBoxSub->itemAt(vBoxSub->count() - 1)->
-                                          widget())->setRemoveButtonEnabled(false);
+                                           widget())->setRemoveButtonEnabled(false);
         }
 
         wgtSub->update();

diff --git a/Window/MainWindow/mainwindow.h b/Window/MainWindow/mainwindow.h
@@ -79,8 +79,8 @@ private slots:
     void GetSourceCaptureImage();
     void GetSourceCaptureError(QString);
     void toggleFlipSource(bool);
-    void addOperation(OPCodes opCode = NONE);
-    void lastOperationChanged(OPCodes opCode);
+    void addOperation(MainWindow::OPCodes opCode = NO_OPERATION);
+    void lastOperationChanged(MainWindow::OPCodes opCode);
     void showAboutDialog();
     void outputLabelLBClicked(int x, int y);
     void showHideExplodedView();