Hide tab bar

[priyanshu16095]

Fixes #9971

This PR introduces a feature to hide the tab bar when only a single library is open in JabRef, enhancing the user interface for devices with low screen space.

THE CHANGES MADE

• When a single library is open, the tab bar is hidden.
• Ensured that the tab bar is restored when more than one library is open, maintaining expected functionality.
• Added the right-click context menu option to the menu > library to retain the functionality.

• I own the copyright of the code submitted and I licence it under the MIT license
• Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[priyanshu16095]

This PR resolves the issues from the previous ones and has passed all the checks.
I have also learned about Git branching.

[priyanshu16095]

@calixtus Should I add the option to turn this behavior on or off here?

[calixtus]

I would put it rather in workspace preferences. The entry table preferences should focus on the maintable. The tabbedPane itself is part of the frame.

[calixtus]

Do not close a pull request in GitHub. Just push to your branch, GitHub will automatically update your pull request. This way all the discussion in the former pr is gone.

[calixtus]

Continues #12394 and #12393

[calixtus]

Do not forget to add a changelog entry

[priyanshu16095]

Sure, I will not close the PR. By mistake, in the previous PRs, I also added the commits from the copyToOption branch.
I find no other option but to create a new PR.
I will make sure not to repeat this in the future.

[priyanshu16095]

Is the preference correctly placed in the UI?

Created a CSS class that can be added or removed.
Added a preference to control this behavior. (in workspace preference)

Using BindingHelper.subscribeFuture() is not working smoothly.
If no library is present and the preference is set to true, the tab bar is still displayed.
After adding and removing a library, it starts working as expected.

Not using BindingHelper.subscribeFuture() works fine, but if anyone changes the preference, it does not reflects in real time and shows from the next time.

Please review.

[priyanshu16095]

@calixtus The right click context menu has six options:

1. Library Properties:
   can also be accessed from Menu > Library > Library Properties

2. Reveal in file explorer

3. Open terminal here

4. Close library:
   can also be accessed from Menu > File > Close Library

5. Close others:
   No use if there is only a single library

6. Close all:
   Option 4 will function the same

The functionality of option 2 and 3 would be lost.
However, they can be added in the Menu > Library.

A three-dot menu can be placed in the top right of main table to show the same right-click context menu.

[priyanshu16095]

@calixtus Should the close button be placed here?

[calixtus]

Is the preference correctly placed in the UI?

Yes, i like it.

Created a CSS class that can be added or removed. Added a preference to control this behavior. (in workspace preference)

Using BindingHelper.subscribeFuture() is not working smoothly. If no library is present and the preference is set to true, the tab bar is still displayed. After adding and removing a library, it starts working as expected.

Not using BindingHelper.subscribeFuture() works fine, but if anyone changes the preference, it does not reflects in real time and shows from the next time.

Maybe you can use a PseudoClass to distinguish between hidden and shown.

Did you try EasyBind.subscribe()?
Maybe you have to store the Subscription as a class variable to keep it from beeing removed by the garbage collector.

[calixtus]

@calixtus The right click context menu has six options:

1. Library Properties:
   can also be accessed from Menu > Library > Library Properties

2. Reveal in file explorer

3. Open terminal here

4. Close library:
   can also be accessed from Menu > File > Close Library

5. Close others:
   No use if there is only a single library

6. Close all:
   Option 4 will function the same

The functionality of option 2 and 3 would be lost. However, they can be added in the Menu > Library.

A three-dot menu can be placed in the top right of main table to show the same right-click context menu.

@JabRef/developers wdyt?

[Siedlerchr]

I would move all the options to the library menu options. This has the advantage that it can also be shown when you have multiple tabs.

[calixtus]

I would move all the options to the library menu options. This has the advantage that it can also be shown when you have multiple tabs.

Move? Why? We wanted the right-click menu when we introduced oneandahalf year ago.
Question was: do we want an additional three dot menu or just rely on the menu, when only one library is open?

[Siedlerchr]

When one library is open we rely on the menu. I find another 3 dot thing confusing

[priyanshu16095]

The feature is working fine, it observes both the number of open databases and reflects real-time changes based on the value of the checkbox.

Please review

Recording.2025-01-20.mp4

[priyanshu16095]

I am unable to add the 'Open in File Explorer' option because the OpenDatabaseFolder class inside JabRefFrame is private.

jabref/src/main/java/org/jabref/gui/frame/JabRefFrame.java

Line 633 in bd7219f

private class OpenDatabaseFolder extends SimpleCommand {

[HoussemNasri]

We can just make it public and static so we can create instances of it without needing JabRefFrame

[priyanshu16095]

Is the feature complete, or does it also require a close button?

Recording.2025-01-22.mp4

[HoussemNasri]

Protip: videos can drag & dropped in GitHub comments and they will be uploaded automatically :)

I don't know whether this is complete or not, Carl and Chris would be of a better help. But this reviewable at least so let's undraft it.

[priyanshu16095]

Protip: videos can drag & dropped in GitHub comments and they will be uploaded automatically :)

It says the video is too large. I will compress and use it.

[HoussemNasri]

The software you use for recording should have done the compression automatically; 17 seconds of video being too large is weird. Try to tinker around with its settings.

[Siedlerchr]

Would you please resolve the conflicts and address the review comments so we can get this ready?

[priyanshu16095]

@Siedlerchr Done.