Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Error a struct instead of an enum to hide implementation #40

Merged
merged 13 commits into from
Feb 1, 2024

remove inline from display impl on error

5c7ac92
Select commit
Loading
Failed to load commit list.
Merged

Make Error a struct instead of an enum to hide implementation #40

remove inline from display impl on error
5c7ac92
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2024 in 0s

94.23% (+0.11%) compared to 8875b54

View this Pull Request on Codecov

94.23% (+0.11%) compared to 8875b54

Details

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (8875b54) 94.11% compared to head (5c7ac92) 94.23%.

Files Patch % Lines
common/src/error.rs 80.48% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   94.11%   94.23%   +0.11%     
==========================================
  Files           6        6              
  Lines         765      728      -37     
==========================================
- Hits          720      686      -34     
+ Misses         45       42       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov