Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code slightly in roundmultiple #1172

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

seanmcleod
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 25.12%. Comparing base (5979050) to head (ef2c0d1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/math/FGFunction.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1172   +/-   ##
=======================================
  Coverage   25.12%   25.12%           
=======================================
  Files         170      170           
  Lines       18337    18337           
=======================================
  Hits         4608     4608           
  Misses      13729    13729           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agodemar
Copy link
Contributor

@seanmcleod is it OK to merge?

@seanmcleod
Copy link
Member Author

@agodemar although fairly trivial changes I'd prefer to wait for @bcoconni to double-check them first, especially since they were made in response to some of his suggestions. And he's very good at spotting issues/better ways to do things as well 😉

Lastly there is no rush. There is an implementation already in master that users can start making use of, this is really just a bit of tidying up of the code.

@bcoconni
Copy link
Member

I'd prefer to wait for @bcoconni to double-check them first, especially since they were made in response to some of his suggestions. And he's very good at spotting issues/better ways to do things as well 😉

Thanks for the pat on the back 😄
Looks good to me.

@bcoconni bcoconni linked an issue Oct 12, 2024 that may be closed by this pull request
1 task
@seanmcleod seanmcleod merged commit 0f00b80 into JSBSim-Team:master Oct 12, 2024
30 checks passed
bcoconni pushed a commit to bcoconni/jsbsim that referenced this pull request Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: round tag
3 participants