Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role="button" to chosen-single class link #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

juanolalla
Copy link

@juanolalla juanolalla commented Sep 25, 2023

Summary

Adds role="button" attribute to <a class="chosen-single">. It also adds an aria-label to inform screen readers what will happen if you click the button, "Show options" or "Hide options".

Hides the visual arrow up/down indicator container from screen readers with aria-hidden.

Please double-check that:

  • All changes were made in CoffeeScript files, not JavaScript files.
  • You used Grunt to build the JavaScript files and tested them locally.
  • You've updated both the jQuery and Prototype versions.
  • You haven't manually updated the version number in package.json.
  • If necessary, you've updated the documentation.

See the Pull Requests section of our Contributing Guidelines for more details.

References

Solves #52

juanolalla added a commit to juanolalla/chosen that referenced this pull request Sep 25, 2023
juanolalla added a commit to juanolalla/chosen that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant