Add patch for py-netcdf4 so that we can build it ~mpi #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en netCDF was built with +mpi
Merged
4 tasks
climbfuji
changed the title
| @@ -42,9 +42,9 @@ class PyNetcdf4(PythonPackage): | |||
| # https://github.com/Unidata/netcdf4-python/pull/1317 | |||
| depends_on("py-numpy@:1", when="@:1.6", type=("build", "link", "run")) | |||
| depends_on("py-mpi4py", when="+mpi", type=("build", "run")) | |||
| depends_on("netcdf-c", when="-mpi") | |||
| depends_on("netcdf-c", when="~mpi") | |||
There was a problem hiding this comment.
I would take out the when="~mpi" but functionally I don't think it matters.
AlexanderRichert-NOAA
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patch for
py-netcdf4so that we can build it~mpiwhennetcdf-cwas built with+mpi. See JCSDA/spack-stack#1463 for more information.See JCSDA/spack-stack#1464 for testing.