forked from spack/spack
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cylc-flow, cylc-rose, cylc-uiserver from spack develop; update setup-meta-modules extension for Python #377
Merged
climbfuji
merged 28 commits into
JCSDA:jcsda_emc_spack_stack
from
climbfuji:feature/add_cylc_flow
Dec 13, 2023
Merged
Add cylc-flow, cylc-rose, cylc-uiserver from spack develop; update setup-meta-modules extension for Python #377
climbfuji
merged 28 commits into
JCSDA:jcsda_emc_spack_stack
from
climbfuji:feature/add_cylc_flow
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/add_cylc_flow
…ert-noaa/spack into feature/add_cylc_flow
…ack-stack/stack/meta_modules.py) for finding Python
…ert-noaa/spack into feature/add_cylc_flow
6 tasks
…into feature/add_cylc_flow
climbfuji
changed the title
Add cylc-flow, cylc-rose, cylc-uiserver from spack develop
Add cylc-flow, cylc-rose, cylc-uiserver from spack develop; update setup-meta-modules extension for Python
Dec 7, 2023
…into feature/add_cylc_flow
climbfuji
requested review from
srherbener,
ulmononian,
DavidHuber-NOAA,
AlexanderRichert-NOAA,
BenjaminRuston,
RatkoVasic-NOAA and
natalie-perlin
December 12, 2023 16:57
srherbener
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing JCSDA/spack-stack/issues/865!
ulmononian
approved these changes
Dec 12, 2023
climbfuji
added a commit
to JCSDA/spack-stack
that referenced
this pull request
Dec 14, 2023
Necessary config and spack submodule pointer updates for adding cylc-flow, cylc-rose, cylc-uiserver. Along with this, bump Python to version 3.10.13 (see JCSDA/spack#377 for some background information on why we can use newer Python versions than 3.9 with cylc in spack-stack. This Python version is also compatible with what is requested in #887. I removed several legacy versions for Python packages as part of this process, since I ran into problems with duplicate packages. Co-authored-by: Alex Richert <[email protected]> Co-authored-by: Alex Richert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pip
installs) because of a bug fix topy-graphene-tornado
(wrong dependency version forpy-werkzeug
- see Update py-werkzeug version dependency for [email protected] spack/spack#41426).[email protected]:
with Intel, do not apply patch since it's already included in the source code. See Skip 'icc.patch' for [email protected]+ spack/spack#41568 (cherry-picked change from this PR and sent to spack develop)spack stack setup-meta-modules
extension to handle Python dependencies better. This fixes In a chained environment, setup-meta-modules doesn't find python from the upstream environment spack-stack#865 (tested locally on my macOS).For more information on testing, see JCSDA/spack-stack#894.
Issue(s) addressed
Working towards JCSDA/spack-stack#242
Fixes JCSDA/spack-stack#865
Dependencies
n/a
Impact
n/a
Checklist
I have made corresponding changes to the documentation