Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cylc-flow, cylc-rose, cylc-uiserver from spack develop; update setup-meta-modules extension for Python #377

Merged
merged 28 commits into from
Dec 13, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 7, 2023

Description

  1. This PR pulls updates from spack develop that were made between nov2023_spackmerge and now, and additional bug fixes that I submitted to spack develop, for building cylc-flow, cylc-rose, and cylc-uiserver. Notably, with spack builds, we are not constrained by Python versions 3.9.18 or less (unlike pip installs) because of a bug fix to py-graphene-tornado (wrong dependency version for py-werkzeug - see Update py-werkzeug version dependency for [email protected] spack/spack#41426).
  2. Bug fix for [email protected]: with Intel, do not apply patch since it's already included in the source code. See Skip 'icc.patch' for [email protected]+ spack/spack#41568 (cherry-picked change from this PR and sent to spack develop)
  3. In separate commits, this PR updates the spack stack setup-meta-modules extension to handle Python dependencies better. This fixes In a chained environment, setup-meta-modules doesn't find python from the upstream environment spack-stack#865 (tested locally on my macOS).

For more information on testing, see JCSDA/spack-stack#894.

Issue(s) addressed

Working towards JCSDA/spack-stack#242
Fixes JCSDA/spack-stack#865

Dependencies

n/a

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji climbfuji changed the title Add cylc-flow, cylc-rose, cylc-uiserver from spack develop Add cylc-flow, cylc-rose, cylc-uiserver from spack develop; update setup-meta-modules extension for Python Dec 7, 2023
Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing JCSDA/spack-stack/issues/865!

@climbfuji climbfuji merged commit 922c1c1 into JCSDA:jcsda_emc_spack_stack Dec 13, 2023
4 of 5 checks passed
@climbfuji climbfuji deleted the feature/add_cylc_flow branch December 13, 2023 16:37
climbfuji added a commit to JCSDA/spack-stack that referenced this pull request Dec 14, 2023
Necessary config and spack submodule pointer updates for adding cylc-flow, cylc-rose, cylc-uiserver.

Along with this, bump Python to version 3.10.13 (see JCSDA/spack#377 for some background information on why we can use newer Python versions than 3.9 with cylc in spack-stack. This Python version is also compatible with what is requested in #887.

I removed several legacy versions for Python packages as part of this process, since I ran into problems with duplicate packages.


Co-authored-by: Alex Richert <[email protected]>
Co-authored-by: Alex Richert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

In a chained environment, setup-meta-modules doesn't find python from the upstream environment
5 participants