Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GMAO swell environment file #332

Closed

Conversation

danholdaway
Copy link

@danholdaway danholdaway commented Oct 3, 2023

Description

Add a Swell environment file.

This PR is part of addressing JCSDA/spack-stack#242.

@climbfuji climbfuji self-requested a review October 3, 2023 02:42
@climbfuji climbfuji self-assigned this Oct 3, 2023
@climbfuji climbfuji requested a review from mathomp4 October 3, 2023 02:42
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Oct 3, 2023
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for adding this virtual package. I will test it shortly in the unified environment / skylab environment.


conflicts(
"%gcc platform=darwin",
msg="ewok-env does " + "not build with gcc (11?) on macOS (12), use apple-clang",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's probably true, we haven't tried. But since we don't build with gcc on macOS at all, could you please replace ewok-env in this line with gmao-swell-env and leave it as is otherwise?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed that one. Done.

@danholdaway
Copy link
Author

@climbfuji I forgot to add the specific version of CRTM that we use so I just pushed that.

@climbfuji
Copy link
Collaborator

@danholdaway An update on this. As expected, we can't add it to the unified environment right now, because we get version conflicts (different py-pyyaml requirements), see:

[unified-env] heinzell@JCSDA-L-18146:~/work/spack-stack/spack-stack-swell-env [brew-arch64]> ./util/show_duplicate_packages.py -d log.concretize.unified-env.001
kcr7nsb  [email protected]%[email protected]+fix~ipo  build_system=cmake  build_type=RelWithDebInfo  generator=make  arch=darwin-monterey-m1
ztqgqlq  [email protected]%[email protected]+fix~ipo  build_system=cmake  build_type=RelWithDebInfo  generator=make  arch=darwin-monterey-m1
qnstiqx  [email protected]%[email protected]+fix~ipo  build_system=cmake  build_type=RelWithDebInfo  generator=make  arch=darwin-monterey-m1
aubwuv6  [email protected]%[email protected]+gfs_phys~ipo+openmp+pic+quad_precision+use_fmsio~yaml  build_system=cmake  build_type=Release  constants=GFS  generator=make  precision=32,64  arch=darwin-monterey-m1
vbbn5bx  fms@release-jcsda%[email protected]+gfs_phys~ipo+openmp+quad_precision  build_system=cmake  build_type=Release  generator=make  precision=32  arch=darwin-monterey-m1
3aluzij  [email protected]%[email protected]+gfs_phys~ipo+openmp+pic+quad_precision~yaml  build_system=cmake  build_type=Release  constants=GFS  generator=make  precision=32,64  arch=darwin-monterey-m1
qi6uhr5  [email protected]%[email protected]+fftw+hdf4+python  build_system=bundle  arch=darwin-monterey-m1
5jlheh2  [email protected]%[email protected]+fftw+hdf4+python  build_system=bundle  arch=darwin-monterey-m1
zru6pjg  [email protected]%[email protected]  build_system=python_pip  arch=darwin-monterey-m1
cqd4oes  [email protected]%[email protected]  build_system=python_pip  arch=darwin-monterey-m1
r3i627m  [email protected]%[email protected]+libyaml  build_system=python_pip  arch=darwin-monterey-m1
hgl5zm4  [email protected]%[email protected]+libyaml  build_system=python_pip  arch=darwin-monterey-m1
2j44uni  [email protected]%[email protected]  build_system=bundle  arch=darwin-monterey-m1
2tsmdqv  [email protected]%[email protected]  build_system=bundle  arch=darwin-monterey-m1
===
Duplicates found!

But that's not a big issue, because once #336 is merged we should be able to cleanly switch to awscli-v2 instead of awscli in ewok-env, and the duplicate versions should be gone.

@danholdaway
Copy link
Author

Thank you @climbfuji. Thanks for making the awscli changes so we can get this into the unified env.

Copy link
Collaborator

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve as I trust both @danholdaway and @climbfuji to get this right 😄

@danholdaway
Copy link
Author

@mathomp4 should be create a GEOSgcm environment file at the same time? So we can ensure we have the modules needed to build GEOSgcm? Do you have a list of the all the dependencies. I think they are all in spack at this point right?

@climbfuji
Copy link
Collaborator

This will be merged automatically when JCSDA/spack-stack#813 is merged (no need to close this I believe).

climbfuji added a commit that referenced this pull request Oct 9, 2023
…e_swell

Enable awscli-v2 in ewok-env/jedi-tools-env, update gmao-swell-env (includes PR #332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants