Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate RHEL CI failures #224

Merged

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Feb 8, 2023

Failure was due to setup-env.sh being run as root, which creates the opt/ directory, which then can't be written to by the user spack-test. I don't think there's any reason to run the remove-extension step as root, so this PR modifies it to run with spack-test.

Fixes #223, addresses #202 - @climbfuji Are there any other issues regarding #202 or did I just make a duplicate issue? (:

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review February 9, 2023 01:53
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderRichert-NOAA This is awesome, thanks very much for taking the time to look into this and for coming up with such an easy solution. This fixes #202.

@climbfuji climbfuji linked an issue Feb 9, 2023 that may be closed by this pull request
2 tasks
@climbfuji
Copy link
Collaborator

I should note that we will have to maintain this difference from the authoritative CI test file. We already have some differences in there, so that's not a problem.

@climbfuji climbfuji merged commit 1f8dfd4 into JCSDA:jcsda_emc_spack_stack Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHEL CI failures spack unit tests are failing in our branch
2 participants