Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spack unit tests are failing in our branch #202

Closed
2 tasks done
climbfuji opened this issue Dec 1, 2022 · 0 comments · Fixed by #224
Closed
2 tasks done

spack unit tests are failing in our branch #202

climbfuji opened this issue Dec 1, 2022 · 0 comments · Fixed by #224
Assignees

Comments

@climbfuji
Copy link
Collaborator

Summary

The spack unit tests are failing in our branch, and I don't think we can fix all of them. It looks like some are meant to run only from the authoritative spack repository.

Rationale

No response

Description

We need to decide what to do - turn off the unit tests altogether, or change them so that the offending tests are not run (in a least-intrusive way to maintain merging back and forth with the upstream repo). It's not good practice to just ignore the failing tests for each PR.

Additional information

No response

General information

  • I have run spack --version and reported the version of Spack
  • I have searched the issues of this repo and believe this is not a duplicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants