Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spack submodule from spack/develop as of 2024/01/26 #977

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3066b6b
Update .gitmodules and submodule pointer for spack for code review an…
climbfuji Jan 27, 2024
2366a91
For spack-ext/lib: env.env_file_config_scope_name() --> env.scope_name
climbfuji Jan 29, 2024
8987394
Update macOS site packages.yaml and corresponding documentation in do…
climbfuji Jan 29, 2024
f55f74c
Merge branch 'develop' of https://github.com/jcsda/spack-stack into f…
climbfuji Jan 29, 2024
7f4fb06
Unpin many package versions in configs/common/packages.yaml; remove c…
climbfuji Jan 29, 2024
064ea42
Replace default_list_scope() with None in spack-ext/lib/jcsda-emc/spa…
climbfuji Jan 29, 2024
da87ff5
Update submodule pointer for spack
climbfuji Jan 29, 2024
a521bd0
Update openmpi version for macOS CI runs
climbfuji Jan 30, 2024
edc602a
Skip external gettext for macOS CI
climbfuji Jan 30, 2024
3e568fd
Mark curl as non-buildable for Ubuntu CI to avoid duplicate packages
climbfuji Jan 31, 2024
7bc5302
Revert many updates to configs/common/packages.yaml
climbfuji Feb 1, 2024
11fdc06
Merge branch 'develop' of https://github.com/jcsda/spack-stack into f…
climbfuji Feb 1, 2024
f57dd8c
Revert many more updates in .github, configs and doc
climbfuji Feb 1, 2024
60fa515
Fix macOS Intel CI by adding gettext with correct (non-sys) path
climbfuji Feb 2, 2024
3aa0f62
Avoid duplicate setting of CMAKE_PREFIX_PATH in configs/common/module…
climbfuji Feb 2, 2024
ff91325
Merge branch 'develop' of https://github.com/jcsda/spack-stack into f…
climbfuji Feb 2, 2024
5c94aba
Update submodule pointer for spack
climbfuji Feb 2, 2024
15f5dab
Merge branch 'develop' of https://github.com/jcsda/spack-stack into f…
climbfuji Feb 5, 2024
8bd29c7
Merge branch 'develop' of https://github.com/jcsda/spack-stack into f…
climbfuji Feb 7, 2024
0c40292
Remove variant '+download_boost' for mysql from configs/common/packag…
climbfuji Feb 7, 2024
290ff2b
Revert .gitmodules and update submodule pointer for spack
climbfuji Feb 7, 2024
0ade34d
Add '--exclude python' to 'spack external find' in documentation and …
climbfuji Feb 7, 2024
1247e9b
Update .github/workflows/macos-ci-x86_64.yaml
climbfuji Feb 7, 2024
05d44b4
Change 'spack.config.get(repos, scope=None)' to 'spack.config.get(rep…
climbfuji Feb 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/macos-ci-aarch64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ jobs:
export SPACK_SYSTEM_CONFIG_PATH="${ENVDIR}/site"

# Find external packages
spack external find --scope system --exclude bison --exclude openssl
spack external find --scope system \
--exclude bison --exclude openssl \
--exclude python
spack external find --scope system perl
spack external find --scope system wget
PATH="/opt/homebrew/opt/curl/bin:$PATH" \
Expand All @@ -77,7 +79,7 @@ jobs:
# *DH

# Set compiler and MPI
spack config add "packages:all:providers:mpi:[openmpi@4.1.6]"
spack config add "packages:all:providers:mpi:[openmpi@5.0.1]"
spack config add "packages:all:compiler:[[email protected]]"
sed -i '' "s/\['\%aocc', '\%apple-clang', '\%gcc', '\%intel'\]/\['\%apple-clang'\]/g" $ENVDIR/spack.yaml

Expand Down Expand Up @@ -136,7 +138,7 @@ jobs:

module use ${ENVDIR}/install/modulefiles/Core
module load stack-apple-clang/14.0.3
module load stack-openmpi/4.1.6
module load stack-openmpi/5.0.1
module load stack-python/3.10.13
module available

Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/macos-ci-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ jobs:
export SPACK_SYSTEM_CONFIG_PATH="${ENVDIR}/site"

# Find external packages
spack external find --scope system --exclude bison --exclude openssl
spack external find --scope system \
--exclude bison --exclude openssl \
--exclude python --exclude gettext
# Need to find gettext outside of default (presumed to be a system) path for krb5
spack external find --path=/usr/local/Cellar/gettext/0.21.1 gettext
spack external find --scope system perl
spack external find --scope system wget
PATH="/usr/local/opt/curl/bin:$PATH" \
Expand All @@ -70,7 +74,7 @@ jobs:
# *DH

# Set compiler and MPI
spack config add "packages:all:providers:mpi:[openmpi@4.1.6]"
spack config add "packages:all:providers:mpi:[openmpi@5.0.1]"
spack config add "packages:all:compiler:[[email protected]]"
sed -i '' "s/\['\%aocc', '\%apple-clang', '\%gcc', '\%intel'\]/\['\%apple-clang'\]/g" $ENVDIR/spack.yaml

Expand Down Expand Up @@ -127,7 +131,7 @@ jobs:

module use ${ENVDIR}/install/modulefiles/Core
module load stack-apple-clang/14.0.0
module load stack-openmpi/4.1.6
module load stack-openmpi/5.0.1
module load stack-python/3.10.13
module available

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/ubuntu-ci-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ jobs:
export SPACK_SYSTEM_CONFIG_PATH="${ENVDIR}/site"

# Find external packages
spack external find --scope system --exclude bison --exclude openssl
spack external find --scope system \
--exclude bison --exclude openssl \
--exclude python
spack external find --scope system sed
spack external find --scope system perl
spack external find --scope system wget
Expand Down
2 changes: 0 additions & 2 deletions configs/common/modules_lmod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -285,5 +285,3 @@ modules:
- PKG_CONFIG_PATH
lib64/pkgconfig:
- PKG_CONFIG_PATH
'':
- CMAKE_PREFIX_PATH
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a duplicate, spack sets this variable automatically

2 changes: 0 additions & 2 deletions configs/common/modules_tcl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -284,5 +284,3 @@ modules:
- PKG_CONFIG_PATH
lib64/pkgconfig:
- PKG_CONFIG_PATH
'':
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

- CMAKE_PREFIX_PATH
27 changes: 12 additions & 15 deletions configs/common/packages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
ecbuild:
version: ['3.7.2']
eccodes:
version: ['2.32.0']
version: ['2.33.0']
variants: +png
ecflow:
version: ['5.11.4']
Expand All @@ -49,7 +49,7 @@
version: ['1.24.5']
variants: linalg=eigen,lapack compression=lz4,bzip2
ecmwf-atlas:
version: ['0.35.1']
version: ['0.36.0']
variants: +fckit +trans +tesselation +fftw
ectrans:
version: ['1.2.0']
Expand Down Expand Up @@ -113,7 +113,7 @@
version: ['4.2.15']
variants: +external-xdr ~fortran ~netcdf
hdf5:
version: ['1.14.0']
version: ['1.14.3']
ulmononian marked this conversation as resolved.
Show resolved Hide resolved
variants: +hl +fortran +mpi ~threadsafe ~szip
ip:
version: ['4.3.0']
Expand All @@ -124,8 +124,6 @@
version: ['2.0.32']
jedi-cmake:
version: ['1.4.0']
jpeg:
version: ['9.1.0']
landsfcutil:
version: ['2.4.1']
libjpeg-turbo:
Expand All @@ -148,10 +146,8 @@
require: "+int64 +real64"
mpich:
variants: ~hwloc +two_level_namespace
mysql:
variants: +download_boost
nco:
version: ['5.0.6']
version: ['5.1.6']
variants: ~doc
# ncview - when adding information here, also check Orion
# and Discover site configs
Expand Down Expand Up @@ -183,17 +179,17 @@
version: ['0.3.24']
variants: +noavx512
openmpi:
variants: +internal-hwloc +two_level_namespace
variants: ~internal-hwloc +two_level_namespace
# Pin openssl to avoid duplicate packages being built
openssl:
variants: +shared
p4est:
version: ['2.8']
parallelio:
version: ['2.5.10']
version: ['2.6.2']
variants: +pnetcdf
parallel-netcdf:
version: ['1.12.2']
version: ['1.12.3']
pflogger:
version: ['1.12.0']
variants: +mpi
Expand Down Expand Up @@ -221,6 +217,9 @@
# to avoid duplicate packages being built (cylc dependencies soft-want @3:)
py-cython:
require: "@0.29.36"
## https://github.com/JCSDA/spack-stack/issues/980
#py-gitpython:
# require: "@3.1.27"
py-h5py:
version: ['3.7.0']
variants: ~mpi
Expand All @@ -237,9 +236,6 @@
require: ['@1.22.3']
py-pandas:
variants: +excel
# To avoid pip._vendor.pep517.wrappers.BackendInvalid errors with newer
# versions of py-poetry-core when using external/homebrew Python as
# we do at the moment in spack-stack.
# Pin the py-setuptools version to avoid duplicate Python packages
py-setuptools:
require: ['@63.4.3']
Expand All @@ -263,6 +259,7 @@
variants: precision=4,d,8
udunits:
version: ['2.2.28']
# Note - we can remove upp from stack at some point?
upp:
version: ['10.0.10']
w3emc:
Expand All @@ -278,7 +275,7 @@
wrf-io:
version: ['1.2.0']
yafyaml:
version: ['0.5.1']
version: ['1.2.0']
zlib:
version: ['1.2.13']
zstd:
Expand Down
8 changes: 5 additions & 3 deletions doc/source/NewSiteConfigs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,9 @@ Remember to activate the ``lua`` module environment and have MacTeX in your sear

.. code-block:: console

spack external find --scope system --exclude bison --exclude openssl
spack external find --scope system \
--exclude bison --exclude openssl \
--exclude python
spack external find --scope system libiconv
spack external find --scope system perl
spack external find --scope system wget
Expand Down Expand Up @@ -249,7 +251,7 @@ Remember to activate the ``lua`` module environment and have MacTeX in your sear
# Check your clang version then add it to your site compiler config.
clang --version
spack config add "packages:all:compiler:[apple-clang@YOUR-VERSION]"
spack config add "packages:all:providers:mpi:[openmpi@4.1.6]"
spack config add "packages:all:providers:mpi:[openmpi@5.0.1]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good update too. Perhaps this will help with the MacOS build issue #971?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe


8. If applicable (depends on the environment), edit the main config file for the environment and adjust the compiler matrix to match the compilers for macOS, as above:

Expand Down Expand Up @@ -449,7 +451,7 @@ It is recommended to increase the stacksize limit by using ``ulimit -S -s unlimi
spack external find --scope system \
--exclude bison --exclude cmake \
--exclude curl --exclude openssl \
--exclude openssh
--exclude openssh --exclude python
spack external find --scope system wget
spack external find --scope system mysql
spack external find --scope system texlive
Expand Down
2 changes: 1 addition & 1 deletion spack
Submodule spack updated 8794 files
4 changes: 2 additions & 2 deletions spack-ext/lib/jcsda-emc/spack-stack/stack/stack_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def write(self):
# Activate environment
env = ev.Environment(manifest_dir=env_dir)
ev.activate(env)
env_scope = env.env_file_config_scope_name()
env_scope = env.scope_name

# Save original data in spack.yaml because it has higest precedence.
# spack.config.add will overwrite as it goes.
Expand Down Expand Up @@ -271,7 +271,7 @@ def write(self):
os.makedirs(env_pkgs_path, exist_ok=False)
with open(os.path.join(env_repo_path, "repo.yaml"), "w") as f:
f.write("repo:\n namespace: envrepo")
repo_paths = spack.config.get("repos", scope=spack.config.default_list_scope())
repo_paths = spack.config.get("repos")
repo_paths = [p.replace("$spack/", spack.paths.spack_root + "/") for p in repo_paths]
for pkg_name in self.modifypkg:
pkg_found = False
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def test_setup_meta_modules():

# Setup env and pretend that a build exists
# by creating the module directory structure.
scope = env.env_file_config_scope_name()
scope = env.scope_name
spack.config.add("packages:all:compiler:[{}]".format(comp), scope=scope)
spack.config.add("packages:all:providers:mpi:[{}]".format(mpi), scope=scope)
spack.config.add("packages:openmpi:version:[{}]".format(mpi_ver))
Expand Down
Loading