-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for geos-gcm to spack-stack (add mepo, geos-gcm-env; update esmf/mapl variants) #953
Merged
climbfuji
merged 84 commits into
JCSDA:develop
from
climbfuji:feature/geos_gcm_dependencies
Jan 18, 2024
Merged
Add support for geos-gcm to spack-stack (add mepo, geos-gcm-env; update esmf/mapl variants) #953
climbfuji
merged 84 commits into
JCSDA:develop
from
climbfuji:feature/geos_gcm_dependencies
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
added
INFRA
JEDI Infrastructure
NOAA-EMC
OAR-EPIC
NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center
labels
Jan 16, 2024
3 tasks
…eature/geos_gcm_dependencies
mathomp4
reviewed
Jan 17, 2024
@@ -142,7 +142,7 @@ | |||
# https://github.com/JCSDA/spack-stack/issues/769 | |||
# also: ... extdata2g segfault UFS? | |||
version: ['2.40.3'] | |||
variants: ~shared ~extdata2g ~pflogger | |||
variants: +shared +pflogger ~f2py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that I think these are all the defaults of mapl. But probably good to keep them explicit until people get used to it. :)
mathomp4
approved these changes
Jan 17, 2024
Thanks for the review @mathomp4 . Now I have to figure out the CI build failures (pflogger on ubuntu with intel, esmf static on macOS). |
…eature/geos_gcm_dependencies
4 tasks
climbfuji
force-pushed
the
feature/geos_gcm_dependencies
branch
from
January 18, 2024 03:30
46d609d
to
5e26435
Compare
climbfuji
requested review from
ulmononian,
AlexanderRichert-NOAA and
mathomp4
January 18, 2024 16:29
AlexanderRichert-NOAA
approved these changes
Jan 18, 2024
ulmononian
approved these changes
Jan 18, 2024
…eature/geos_gcm_dependencies
…eature/geos_gcm_dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the spack submodule pointer for the changes described in JCSDA/spack#372: add package
mepo
and meta-packagegeos-gcm-env
. The PR also re-enables the shared variant foresmf
, see additional information below as to why that is. Finally, it addsgeos-gcm-env
toskylab-dev
andunified-dev
.Update 2024-01-17:
mpi
variant forpflogger
at least on the Ubuntu AWS ParallelCluster systems for the reasons described in Installation issue: pflogger: MPI is picked up and enabled when variant is set to false spack/spack#42137 (see also Should pflogger have an option for enabling/disabling MPI Goddard-Fortran-Ecosystem/pFlogger#106).Additional information
mapl
module for now. However, to facilitate a future switch to spack-stackmapl
, we update themapl
config accordingly.esmf
andmapl
are ... interesting. Ifesmf
is static, thenmapl
needs to be static. Ifesmf
is shared, thenmapl
needs to be shared. Violate these requirements and you'll be hit withdouble-free corruption
segmentation faults when an executable unwinds its stack upon exit. See Add mepo and geos-gcm-env spack#372 and Possible missing MPI_Type_free in ESMCI_VMKernel? esmf-org/esmf#209 for more information.esmf
to support its sharedmapl
, and there is really no reason why we should restrict theesmf
build to static only because of the UFS. If the UFS requires a staticesmf
, but its build system uses the shared version when both are available, then the UFS needs to be fixed (not spack-stack trimmed down to staticesmf
).Testing
geos-gcm-env
on macOS with apple-clang, on AWS ParallelCluster with intel and gnu, and on Discover with intel and gnugeos-gcm
(branchgeos-cf
) on Discover and ran a one-day c12 end-to-end experiment (thanks to @mathomp4 for all his help)Applications affected
GEOS and UFS applications (the latter because
esmf
is now also available as shared library)Systems affected
All
Dependencies
Issue(s) addressed
Finally! Resolves #242
Checklist