Update GNU container recipe, add Clang container

[climbfuji]

Description

1. Update ubuntu-gnu-openmpi docker recipe:
   • use the default [email protected] compiler instead of [email protected] - there were problems with both of them in the container build
   • use a few more external packages such as qt@5 and wget
   • set environment variable TZ to avoid the container build hanging indefinitely in the final phase when installing tzdata
   • do not strip binaries after build to avoid warnings at end of build process
   • Use new functionality of extra instructions in pre-build and pre-final phases
2. Add ubuntu-clang-mpich docker recipe, almost identical to ubuntu-gnu-openmpi with minimal necessary changes
3. Add README.md in configs/containers to list the specs to install for each spack-stack release and application

Notes

• CI tests passed for 5f89cd0 (this includes installing py-f90nml and py-xarray)
• Also fixed two small errors in doc/source/Platforms.rst
• Waiting on Add extra instructions for container pre-build/pre-final phases for Docker and Singularity. Add additional env variables to Ubuntu 20.04 containers. spack#162 (merged)
• Waiting on Add xarray and f90nml to jedi-base-env, remove npm from jedi-tools-env spack#169 (merged)
• Fixes Need container extra instructions prior to build phase spack#163

[climbfuji]

Excellent: on the new clang+mpich container, only the folllowing three tests fail in jedi-bundle:

Total Test time (real) = 9047.02 sec

The following tests FAILED:
	1165 - ufo_test_tier1_test_ufo_conventionalprofileprocessing_UInterp_OPScomparison (Failed)
	1317 - test_soca_convertstate (Failed)
	1375 - test_soca_3dvarlowres_soca (Failed)
Errors while running CTest
Output from these tests are in: /root/jedi/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.

[climbfuji]

For jedi-bundle ctest failures with gcc+openmpi, see https://github.com/JCSDA-internal/jedi-bundle/issues/12

[climbfuji]

@mer-a-o This is definitely ready for testing from your side. See comments in this PR about my testing etc.

[mer-a-o]

This line doesn't need && \. However, after removing && \ I still get and error with docker build command complaining about extra && in the Dockerfile. I had remove the space between && and \ in for it to work, which doesn't make much sense. So with this I didn't get the error about extra &&

ENV DEBIAN_FRONTEND=noninteractive &&\
TZ=Etc/UTC

The error I get:

Error response from daemon: failed to parse Dockerfile: Syntax error - can't find = in "&&". Must be of the form: name=value

[mer-a-o]

ok, I figured it out. You don't need && in ENV. So it should be

        ENV DEBIAN_FRONTEND=noninteractive 
        TZ=Etc/UTC

[mer-a-o]

Please remove &&\ from here too. Thanks.

[mer-a-o]

Building clang container failed with this error:

==> Error: ProcessError: Command exited with status 2:
    'make' '-j2'

2 errors found in build log:
     1     ==> pigz: Executing phase: 'edit'
     2     ==> [2022-09-07-19:16:46.811453] Using default implementation: skipp
           ing edit phase.
     3     ==> pigz: Executing phase: 'build'
     4     ==> [2022-09-07-19:16:46.833180] 'make' '-j2'
     5     gcc -O3 -Wall -Wextra -Wno-unknown-pragmas -Wcast-qual   -c -o pigz.
           o pigz.c
     6     gcc -O3 -Wall -Wextra -Wno-unknown-pragmas -Wcast-qual   -c -o yarn.
           o yarn.c
  >> 7     pigz.c:415:10: fatal error: zlib.h: No such file or directory
     8       415 | #include "zlib.h"       // deflateInit2(), deflateReset(), d
           eflate(),
     9           |          ^~~~~~~~
     10    compilation terminated.
  >> 11    make: *** [<builtin>: pigz.o] Error 1
     12    make: *** Waiting for unfinished jobs....

See build log for details:
  /tmp/root/spack-stage/spack-stage-pigz-2.7-fhhp3sk4w6ipgtmjsc7cdinvbpuaqe6x/spack-build-out.txt

[climbfuji]

Building clang container failed with this error:

==> Error: ProcessError: Command exited with status 2:
    'make' '-j2'

2 errors found in build log:
     1     ==> pigz: Executing phase: 'edit'
     2     ==> [2022-09-07-19:16:46.811453] Using default implementation: skipp
           ing edit phase.
     3     ==> pigz: Executing phase: 'build'
     4     ==> [2022-09-07-19:16:46.833180] 'make' '-j2'
     5     gcc -O3 -Wall -Wextra -Wno-unknown-pragmas -Wcast-qual   -c -o pigz.
           o pigz.c
     6     gcc -O3 -Wall -Wextra -Wno-unknown-pragmas -Wcast-qual   -c -o yarn.
           o yarn.c
  >> 7     pigz.c:415:10: fatal error: zlib.h: No such file or directory
     8       415 | #include "zlib.h"       // deflateInit2(), deflateReset(), d
           eflate(),
     9           |          ^~~~~~~~
     10    compilation terminated.
  >> 11    make: *** [<builtin>: pigz.o] Error 1
     12    make: *** Waiting for unfinished jobs....

See build log for details:
  /tmp/root/spack-stage/spack-stage-pigz-2.7-fhhp3sk4w6ipgtmjsc7cdinvbpuaqe6x/spack-build-out.txt

I just fixed a minor bug in the pre_final/final instructions for the clang container. With those, unrelated to your error, I could build the container just fine. I am using Docker version 20.10.14, build a224086 on my macOS.

[climbfuji]

@mer-a-o This is ready for review.

[climbfuji]

I am going to merge this now. Any updates needed will be made in a follow-up PR. Thanks for the review, @mer-a-o!