Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spack for latest changes in crtm, esmf and mapl #315

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Aug 23, 2022

This PR updates the submodule pointer for spack for the latest changes in the followin spack PRs:

This is a good time to run the CI tests and the self-hosted build on Dom's macOS. Changes triggered by this:

  • Update GitHub actions template for Dom's macOS (similar to what was done for the other templates when the updates from the official spack repository were brought over)
  • Update documentation: [email protected] is now the default/latest version, update "Known issues" section

@climbfuji
Copy link
Collaborator Author

CI tests passed for all GitHub runners for commit a93066c, but not for Dom's macOS (build error for Met): https://github.com/NOAA-EMC/spack-stack/runs/7965079621?check_suite_focus=true - investigating.

@climbfuji
Copy link
Collaborator Author

CI tests, including Dom's macOS, passed for the latest commit f4bf2aa (even though the red cross suggests differently, click on it and you'll see that all tests passed).

@climbfuji climbfuji marked this pull request as ready for review August 24, 2022 13:50
@climbfuji
Copy link
Collaborator Author

@edwardhartnett @Hang-Lei-NOAA Can I get a review for this PR, please?

Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the update!

@climbfuji climbfuji merged commit 0a73b3e into JCSDA:develop Aug 24, 2022
@climbfuji climbfuji deleted the feature/update_spack_esmf_mapl_crtm branch August 24, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants