Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WCOSS2 site config #1458

Open
wants to merge 14 commits into
base: release/1.9.0
Choose a base branch
from

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Jan 17, 2025

Summary

Add WCOSS2 configuration prior to 1.9.0 release.

Testing

Tested concretize, install, and module build on Acorn (note the use of core_compilers, i.e., no more metamodules).

Applications affected

NCO stack

Systems affected

Acorn/WCOSS2

Dependencies

none

Issue(s) addressed

NOAA-EMC/WCOSS2-requests#13

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review January 23, 2025 06:49
@AlexanderRichert-NOAA
Copy link
Collaborator Author

@WeiWei-NCO please take a look if you get a chance. This should encapsulate everything I've already incorporated into release/1.6.0-nco, idea being that in the future, starting with 1.9.0, we shouldn't need a separate NCO branch.

@WeiWei-NCO
Copy link

WeiWei-NCO commented Jan 23, 2025

Nothing jumps out at me.

starting with 1.9.0, we shouldn't need a separate NCO branch.

As long as each code delivery from EMC has a new version number, and only the related files get updated. We don't expect many spack-stack changes or package.yaml changes in the spack sub when the delivery is only to upgrade certain library/libraries.

@climbfuji climbfuji changed the base branch from develop to release/1.9.0 January 29, 2025 15:29
@climbfuji
Copy link
Collaborator

@AlexanderRichert-NOAA I changed the base branch to release/1.9.0 (let's merge site config updates directory into the release branch, then bring everything back to develop once the release is tagged). Can you please merge this when you think it is ready (maybe ping @Hang-Lei-NOAA to review and approve)?

@AlexanderRichert-NOAA
Copy link
Collaborator Author

Sounds good, will do, thanks.

I need to revert one module-related change then this is ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants