Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intel and gcc containers - fix builds and move to ubuntu 24.04 #1432

Merged
merged 19 commits into from
Dec 23, 2024

Conversation

eap
Copy link
Collaborator

@eap eap commented Dec 22, 2024

This change updates the Intel and GCC containers fixing the intel build and updating both environments to Ubuntu 24.04 to more closely align with our AWS machine images (AMIs). This update focuses on the Intel and GCC images since they are the core of our supported compiler environments,

What about clang? I will submit a similar fix for clang in an immediate followup change. Container images are especially difficult to update due to their longer builds and slightly different (often conflicting) configuration. I have not included clang in this PR in order to speed the delivery of these two containers (our core supported compiler platforms) and reduce the occurance of merge-related rewrites.

What about oneapi-intel? The new llvm-based intel image will be submitted as a new image config outside the scope of this PR.

Testing

This has been built and tested on an AWS intel instance.

Applications / Systems affected

Presubmit CI and containers.

Issue(s) addressed

Fixes: #1383

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji
Copy link
Collaborator

@eap Ignore the non-container build failures for the purpose of this PR (as long as you are not changing any files used by both, which at the moment you don't). I'll try to fix those tomorrow. I am surprised, though. The CI tests all passed last week for every PR we merged ...

@eap eap requested review from climbfuji and stiggy87 December 23, 2024 16:44
@eap eap requested a review from climbfuji December 23, 2024 17:13
@eap eap merged commit 7ac2aa5 into JCSDA:develop Dec 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JEDI CI container build with Intel broken since update from spack develop as of 2024/10/31
3 participants