-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intel and gcc containers - fix builds and move to ubuntu 24.04 #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eap
commented
Dec 22, 2024
@eap Ignore the non-container build failures for the purpose of this PR (as long as you are not changing any files used by both, which at the moment you don't). I'll try to fix those tomorrow. I am surprised, though. The CI tests all passed last week for every PR we merged ... |
4 tasks
climbfuji
reviewed
Dec 23, 2024
stiggy87
approved these changes
Dec 23, 2024
climbfuji
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the Intel and GCC containers fixing the intel build and updating both environments to Ubuntu 24.04 to more closely align with our AWS machine images (AMIs). This update focuses on the Intel and GCC images since they are the core of our supported compiler environments,
What about clang? I will submit a similar fix for clang in an immediate followup change. Container images are especially difficult to update due to their longer builds and slightly different (often conflicting) configuration. I have not included clang in this PR in order to speed the delivery of these two containers (our core supported compiler platforms) and reduce the occurance of merge-related rewrites.
What about oneapi-intel? The new llvm-based intel image will be submitted as a new image config outside the scope of this PR.
Testing
This has been built and tested on an AWS intel instance.
Applications / Systems affected
Presubmit CI and containers.
Issue(s) addressed
Fixes: #1383
Checklist