Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade ectrans version 1.5.0 to version 1.2.0 #1430

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

srherbener
Copy link
Collaborator

@srherbener srherbener commented Dec 19, 2024

Summary

This PR updates all of the places in the configuration, including containers, to move ectrans back to version 1.2.0. This is being done due to an issue (#1417) where [email protected] will compile successfully with the Intel LLVM based Fortran compiler (ifx) but [email protected] will not compile with ifx.

Testing

  • CI testing for this PR
  • Offline testing with jedi-bundle where the new ECMWF library builds are part of the bundle
    • ECMWF libraries with their latest versions:
      • atlas: 0.40.0
      • ectrans: 1.5.0
      • fiat: 1.4.1
      • eckit: 1.28.3
      • fckit: 0.13.2
    • [email protected] with all the other ECMWF libraries at their latest version is working with both GNU and Intel compiler sets.

Applications affected

JEDI, UFS, etc.

Systems affected

List all systems intentionally or unintentionally affected by this PR.
HPCs, Mac

Dependencies

None

Issue(s) addressed

Fixes #1417

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

Copy link
Contributor

@stiggy87 stiggy87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srherbener for getting to this so quick!

@srherbener srherbener added INTERFACE JEDI Models Interface INFRA JEDI Infrastructure and removed INTERFACE JEDI Models Interface labels Dec 19, 2024
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooner than later, we want to move to mkl with the Intel-based stacks so that we don't need to carry around all these site-specific modifications for packages like ectrans.

@climbfuji climbfuji enabled auto-merge (squash) December 19, 2024 19:08
@climbfuji climbfuji merged commit 491b30f into JCSDA:develop Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error: [email protected] with ifx 2025.0.0
3 participants