Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container builds after #1384 #1429

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 19, 2024

Summary

Update configs/containers/specs/jedi-ci.yaml: unpin Python packages, because configs/common/packages.yaml takes care of this (and gets added to the container build automatically).

Testing

GitHub actions test run: https://github.com/JCSDA/spack-stack/actions/runs/12405612914/job/34632778633 PASSED

Applications affected

JEDI CI

Systems affected

JEDI CI containers

Dependencies

None

Issue(s) addressed

Fixes failing container builds following the merge of #1384 (except Intel for additional, unrelated reasons).

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

…because configs/common/packages.yaml takes care of this
eap added a commit to eap/spack-stack that referenced this pull request Dec 19, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to remove this, and use ip@5 instead. See GEOS-ESM/GSIbec#66 for a boilerplate PR for applications using sp at the moment.

@climbfuji climbfuji requested a review from eap December 19, 2024 12:30
@climbfuji climbfuji marked this pull request as ready for review December 19, 2024 12:31
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Dec 19, 2024
@climbfuji climbfuji self-assigned this Dec 19, 2024
@climbfuji climbfuji requested a review from stiggy87 December 19, 2024 12:32
Copy link
Contributor

@stiggy87 stiggy87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@climbfuji climbfuji changed the title DRAFT: Fix container builds after #1384 Fix container builds after #1384 Dec 19, 2024
@climbfuji climbfuji merged commit 02c3c2d into develop Dec 21, 2024
8 of 9 checks passed
@climbfuji climbfuji deleted the bugfix/container_builds_broken_after_1384 branch December 21, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
Development

Successfully merging this pull request may close these issues.

2 participants