Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pcluster site config to use pcluster 3.9.3 #1210

Merged
merged 6 commits into from
Jul 30, 2024

Conversation

eap
Copy link
Collaborator

@eap eap commented Jul 24, 2024

As detailed in https://github.com/JCSDA-internal/jedi-tools/issues/372 we need to update the parallel cluster from 3.7.1 to 3.9.3. I've built a new site-config and updated the sections in the readme and the site-config assets for this new cluster.

Because this pull request only edited the site configs it was affected by the same test exclusion block noted in #1208 - I've moved the changes discussed there into this pull request ensuring that all required tests run.

@eap eap requested review from climbfuji and fabiolrdiniz July 24, 2024 23:44
@eap eap marked this pull request as ready for review July 24, 2024 23:44
Copy link
Contributor

@fabiolrdiniz fabiolrdiniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @eap!

configs/sites/tier1/aws-pcluster/README.md Show resolved Hide resolved
@eap eap requested a review from climbfuji July 30, 2024 16:10
@climbfuji climbfuji enabled auto-merge (squash) July 30, 2024 17:40
@climbfuji climbfuji disabled auto-merge July 30, 2024 17:40
@climbfuji
Copy link
Collaborator

There is a readthedocs build error - https://readthedocs.org/projects/spack-stack/builds/25158270/

@fabiolrdiniz
Copy link
Contributor

I don't think it's related to this PR:

Running Sphinx v8.0.2
loading translations [en]... done
making output directory... done
Converting `source_suffix = '.rst'` to `source_suffix = {'.rst': 'restructuredtext'}`.
ERROR: Invalid value `None` in intersphinx_mapping['https://docs.python.org/']. Expected a two-element tuple or list.

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/spack-stack/envs/1210/lib/python3.11/site-packages/sphinx/cmd/build.py", line 332, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/spack-stack/envs/1210/lib/python3.11/site-packages/sphinx/application.py", line 277, in __init__
    self.events.emit('config-inited', self.config)
  File "/home/docs/checkouts/readthedocs.org/user_builds/spack-stack/envs/1210/lib/python3.11/site-packages/sphinx/events.py", line 100, in emit
    results.append(listener.handler(self.app, *args))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/spack-stack/envs/1210/lib/python3.11/site-packages/sphinx/ext/intersphinx/_load.py", line 127, in validate_intersphinx_mapping
    raise ConfigError(msg)
sphinx.errors.ConfigError: Invalid `intersphinx_mapping` configuration (1 error).

Configuration error:
Invalid `intersphinx_mapping` configuration (1 error).

But it seems that https://github.com/JCSDA/spack-stack/blob/develop/doc/source/conf.py#L203 should be changed to:

intersphinx_mapping = {'python': ('https://docs.python.org', None)}

@eap eap merged commit 289721c into JCSDA:develop Jul 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants