Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log include, include paths, time formats, time_ref #30

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

matthewrmshin
Copy link
Collaborator

@matthewrmshin matthewrmshin commented Oct 18, 2024

Description

Log on loading include.
Log include paths, time formats and reference time value.
Fix loading from stdin. (Broken by #27.)
Fix environment variable name in docs.
Add quiet mode to avoid printing diagnostics.

Issue(s) addressed

Resolve #29. It will now use the logger to print more diagnostic output to stderr. (Cannot use stdout, because it may be used for the actual output of the resulting YAML file.) The will be the default behaviour, but can be overridden by the --quiet option.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@matthewrmshin matthewrmshin added the bug Something is not working label Oct 18, 2024
@matthewrmshin matthewrmshin self-assigned this Oct 18, 2024
@matthewrmshin matthewrmshin force-pushed the feature/log branch 2 times, most recently from d45deb9 to b6b6f54 Compare October 18, 2024 14:54
Log on loading include.
Log include paths, time formats and reference time value.
Fix loading from stdin.
Fix environment variable name in docs.
sphinx
sphinx-rtd-theme
sphinx<8
sphinx-rtd-theme<3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc build breaks on latest version of sphinx/rtd-theme. It does not tell you why, so restrict the version to a lower one for now. Maybe switch to mkdocs in the future.

@@ -1,2 +1,2 @@
"""Process YAML include files and variable substitutions."""
__version__ = '0.6'
__version__ = '0.6.1'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to create a release right after this, given the bug is a blocker for mo-bundle new stack.

@matthewrmshin matthewrmshin added this to the next release milestone Oct 18, 2024
Copy link
Collaborator

@steoxley steoxley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked through this change, and it seems sensible and good!

Since you have tested it, then this is good to go without any further testing from me

@matthewrmshin matthewrmshin merged commit f657a81 into develop Oct 22, 2024
3 checks passed
@matthewrmshin matthewrmshin deleted the feature/log branch October 22, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add verbose mode
2 participants